svn commit: r1757125 - /jackrabbit/trunk/jackrabbit-data/src/main/java/org/apache/jackrabbit/core/data/AbstractDataStore.java

[mr...@apache.org]

Author: mreutegg
Date: Mon Aug 22 09:32:19 2016
New Revision: 1757125

URL: http://svn.apache.org/viewvc?rev=1757125&view=rev
Log:
JCR-4004: Log exception in AbstractDataStore.getReferenceFromIdentifier()

Apply changes suggested by Woonsan Ko

Modified:
    jackrabbit/trunk/jackrabbit-data/src/main/java/org/apache/jackrabbit/core/data/AbstractDataStore.java

Modified: jackrabbit/trunk/jackrabbit-data/src/main/java/org/apache/jackrabbit/core/data/AbstractDataStore.java
URL: http://svn.apache.org/viewvc/jackrabbit/trunk/jackrabbit-data/src/main/java/org/apache/jackrabbit/core/data/AbstractDataStore.java?rev=1757125&r1=1757124&r2=1757125&view=diff
==============================================================================
--- jackrabbit/trunk/jackrabbit-data/src/main/java/org/apache/jackrabbit/core/data/AbstractDataStore.java (original)
+++ jackrabbit/trunk/jackrabbit-data/src/main/java/org/apache/jackrabbit/core/data/AbstractDataStore.java Mon Aug 22 09:32:19 2016
@@ -17,12 +17,18 @@
 package org.apache.jackrabbit.core.data;
 
 import java.security.SecureRandom;
+
 import javax.crypto.Mac;
 import javax.crypto.spec.SecretKeySpec;
 
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
 
 public abstract class AbstractDataStore implements DataStore {
 
+    private static Logger LOG = LoggerFactory.getLogger(AbstractDataStore.class);
+
     private static final String ALGORITHM = "HmacSHA1";
 
     /**
@@ -91,7 +97,7 @@ public abstract class AbstractDataStore
 
             return id + ':' + encodeHexString(hash);
         } catch (Exception e) {
-            // TODO: log a warning about this exception
+            LOG.error("Failed to hash identifier using MAC (Message Authentication Code) algorithm.", e);
         }
         return null;
     }