You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/12/29 18:28:02 UTC

[GitHub] [flink-connector-opensearch] amirhalatzi opened a new pull request, #4: Update Opensearch dependency to version 2.3

amirhalatzi opened a new pull request, #4:
URL: https://github.com/apache/flink-connector-opensearch/pull/4

   Hi!
   
   During a project we're working on we decided to use Flink over Opensearch 2.3, which seems to have a breaking change of removing the `type` property from responses.
   
   This PR updates the dependency and the relevant tests.
   
   I'd be happy to do any necessary changes to make sure this release is differentiated from the one meant for Opensearch 1.3.
   
   Thanks!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [flink-connector-opensearch] reta commented on pull request #4: [FLINK-30537] Update Opensearch dependency to version 2.3

Posted by GitBox <gi...@apache.org>.
reta commented on PR #4:
URL: https://github.com/apache/flink-connector-opensearch/pull/4#issuecomment-1370221021

   @amirhalatzi the OpenSearch 2.x has JDK-11 baseline (the connector works with 2.x as well). Please correct me if I am wrong, Apache Flink still supports JDK 8 (although it is deprecated).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [flink-connector-opensearch] amirhalatzi commented on pull request #4: [FLINK-30537] Update Opensearch dependency to version 2.3

Posted by GitBox <gi...@apache.org>.
amirhalatzi commented on PR #4:
URL: https://github.com/apache/flink-connector-opensearch/pull/4#issuecomment-1370553620

   @reta you're right. Java 8 is still [supported](https://issues.apache.org/jira/browse/FLINK-25244). As for the current connector working with 2.x - you can see in the PR that the API has changed.
   Any ideas on how to support both versions without upgrading to Java 11?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [flink-connector-opensearch] reta commented on pull request #4: [FLINK-30537] Update Opensearch dependency to version 2.3

Posted by GitBox <gi...@apache.org>.
reta commented on PR #4:
URL: https://github.com/apache/flink-connector-opensearch/pull/4#issuecomment-1370984907

   > @reta you're right. Java 8 is still [supported](https://issues.apache.org/jira/browse/FLINK-25244). As for the current connector working with 2.x - you can see in the PR that the API has changed. Any ideas on how to support both versions without upgrading to Java 11?
   
   @amirhalatzi this is only test code which uses `type`, sadly the Bulk API in 1.x requires it (at least for responses), it might be possible to . The connector's code itself does not use any deprecated APIs though. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [flink-connector-opensearch] boring-cyborg[bot] commented on pull request #4: Update Opensearch dependency to version 2.3

Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on PR #4:
URL: https://github.com/apache/flink-connector-opensearch/pull/4#issuecomment-1367509656

   Thanks for opening this pull request! Please check out our contributing guidelines. (https://flink.apache.org/contributing/how-to-contribute.html)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org