You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Benjamin Schrauwen (JIRA)" <ji...@apache.org> on 2011/07/18 05:54:59 UTC

[jira] [Created] (CASSANDRA-2907) durable_writes flag cannot be changes via the CLI

durable_writes flag cannot be changes via the CLI
-------------------------------------------------

                 Key: CASSANDRA-2907
                 URL: https://issues.apache.org/jira/browse/CASSANDRA-2907
             Project: Cassandra
          Issue Type: Bug
          Components: Core
    Affects Versions: 0.8.1
            Reporter: Benjamin Schrauwen


I am unable to change the durable_writes option in the CLI. Here are the commands to replicate the problem on a clean install:

create keyspace test;
update keyspace test with durable_writes=false;
show keyspaces;

It will still say:

Keyspace: test:
  Replication Strategy: org.apache.cassandra.locator.NetworkTopologyStrategy
  Durable Writes: true
    Options: [datacenter1:1]
  Column Families:


PS: I looked in the tests of the CLI code of CASSANDRA-2683 and saw that the feature actually is not properly tested: the flag is set, but never tested.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (CASSANDRA-2907) durable_writes flag cannot be changes via the CLI

Posted by "Benjamin Schrauwen (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CASSANDRA-2907?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13066773#comment-13066773 ] 

Benjamin Schrauwen commented on CASSANDRA-2907:
-----------------------------------------------

BTW, the logs show this:

INFO 23:44:02,549 Applying migration 2da39610-b0f0-11e0-0000-242d50cf1fbf Update keyspace testrep strategy:NetworkTopologyStrategy{}durable_writes: true to testrep strategy:NetworkTopologyStrategy{}durable_writes: true


> durable_writes flag cannot be changes via the CLI
> -------------------------------------------------
>
>                 Key: CASSANDRA-2907
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-2907
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Core
>    Affects Versions: 0.8.1
>            Reporter: Benjamin Schrauwen
>
> I am unable to change the durable_writes option in the CLI. Here are the commands to replicate the problem on a clean install:
> create keyspace test;
> update keyspace test with durable_writes=false;
> show keyspaces;
> It will still say:
> Keyspace: test:
>   Replication Strategy: org.apache.cassandra.locator.NetworkTopologyStrategy
>   Durable Writes: true
>     Options: [datacenter1:1]
>   Column Families:
> PS: I looked in the tests of the CLI code of CASSANDRA-2683 and saw that the feature actually is not properly tested: the flag is set, but never tested.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (CASSANDRA-2907) durable_writes flag cannot be changed via the CLI (system does not process KsDef.durable_writes option properly).

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CASSANDRA-2907?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13067200#comment-13067200 ] 

Hudson commented on CASSANDRA-2907:
-----------------------------------

Integrated in Cassandra-0.8 #222 (See [https://builds.apache.org/job/Cassandra-0.8/222/])
    fix updating KS with durable_writes=false
patch by pyaskevich; reviewed by jbellis for CASSANDRA-2907

jbellis : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1147974
Files : 
* /cassandra/branches/cassandra-0.8/CHANGES.txt
* /cassandra/branches/cassandra-0.8/src/java/org/apache/cassandra/config/KSMetaData.java
* /cassandra/branches/cassandra-0.8/src/java/org/apache/cassandra/db/migration/UpdateKeyspace.java


> durable_writes flag cannot be changed via the CLI (system does not process KsDef.durable_writes option properly).
> -----------------------------------------------------------------------------------------------------------------
>
>                 Key: CASSANDRA-2907
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-2907
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Core
>    Affects Versions: 0.8.1
>            Reporter: Benjamin Schrauwen
>            Assignee: Pavel Yaskevich
>            Priority: Minor
>             Fix For: 0.8.2
>
>         Attachments: CASSANDRA-2907.patch
>
>
> I am unable to change the durable_writes option in the CLI. Here are the commands to replicate the problem on a clean install:
> create keyspace test;
> update keyspace test with durable_writes=false;
> show keyspaces;
> It will still say:
> Keyspace: test:
>   Replication Strategy: org.apache.cassandra.locator.NetworkTopologyStrategy
>   Durable Writes: true
>     Options: [datacenter1:1]
>   Column Families:
> PS: I looked in the tests of the CLI code of CASSANDRA-2683 and saw that the feature actually is not properly tested: the flag is set, but never tested.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (CASSANDRA-2907) durable_writes flag cannot be changed via the CLI (system does not process KsDef.durable_writes option properly).

Posted by "Pavel Yaskevich (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CASSANDRA-2907?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Pavel Yaskevich updated CASSANDRA-2907:
---------------------------------------

    Attachment: CASSANDRA-2907.patch

rebased with cassandra-0.8 (the latest commit 5616b0235aa4e32e49b58d707de2c98310cf0b9d) 

> durable_writes flag cannot be changed via the CLI (system does not process KsDef.durable_writes option properly).
> -----------------------------------------------------------------------------------------------------------------
>
>                 Key: CASSANDRA-2907
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-2907
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Tools
>    Affects Versions: 0.8.1
>            Reporter: Benjamin Schrauwen
>            Assignee: Pavel Yaskevich
>            Priority: Minor
>              Labels: Core
>             Fix For: 0.8.2
>
>         Attachments: CASSANDRA-2907.patch
>
>
> I am unable to change the durable_writes option in the CLI. Here are the commands to replicate the problem on a clean install:
> create keyspace test;
> update keyspace test with durable_writes=false;
> show keyspaces;
> It will still say:
> Keyspace: test:
>   Replication Strategy: org.apache.cassandra.locator.NetworkTopologyStrategy
>   Durable Writes: true
>     Options: [datacenter1:1]
>   Column Families:
> PS: I looked in the tests of the CLI code of CASSANDRA-2683 and saw that the feature actually is not properly tested: the flag is set, but never tested.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (CASSANDRA-2907) durable_writes flag cannot be changes via the CLI

Posted by "Pavel Yaskevich (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CASSANDRA-2907?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13067002#comment-13067002 ] 

Pavel Yaskevich commented on CASSANDRA-2907:
--------------------------------------------

I have discovered that this is not a CLI but rather a Core problem, I will change a title to reflect that.

> durable_writes flag cannot be changes via the CLI
> -------------------------------------------------
>
>                 Key: CASSANDRA-2907
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-2907
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Tools
>    Affects Versions: 0.8.1
>            Reporter: Benjamin Schrauwen
>            Assignee: Pavel Yaskevich
>            Priority: Minor
>
> I am unable to change the durable_writes option in the CLI. Here are the commands to replicate the problem on a clean install:
> create keyspace test;
> update keyspace test with durable_writes=false;
> show keyspaces;
> It will still say:
> Keyspace: test:
>   Replication Strategy: org.apache.cassandra.locator.NetworkTopologyStrategy
>   Durable Writes: true
>     Options: [datacenter1:1]
>   Column Families:
> PS: I looked in the tests of the CLI code of CASSANDRA-2683 and saw that the feature actually is not properly tested: the flag is set, but never tested.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (CASSANDRA-2907) durable_writes flag cannot be changed via the CLI (system does not process KsDef.durable_writes option properly).

Posted by "Benjamin Schrauwen (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CASSANDRA-2907?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13067041#comment-13067041 ] 

Benjamin Schrauwen commented on CASSANDRA-2907:
-----------------------------------------------

+1

I can confirm that this patch now allows to pass the test I mentioned in the initial post. Thanks for the super fast fix!

> durable_writes flag cannot be changed via the CLI (system does not process KsDef.durable_writes option properly).
> -----------------------------------------------------------------------------------------------------------------
>
>                 Key: CASSANDRA-2907
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-2907
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Tools
>    Affects Versions: 0.8.1
>            Reporter: Benjamin Schrauwen
>            Assignee: Pavel Yaskevich
>            Priority: Minor
>              Labels: Core
>             Fix For: 0.8.2
>
>         Attachments: CASSANDRA-2907.patch
>
>
> I am unable to change the durable_writes option in the CLI. Here are the commands to replicate the problem on a clean install:
> create keyspace test;
> update keyspace test with durable_writes=false;
> show keyspaces;
> It will still say:
> Keyspace: test:
>   Replication Strategy: org.apache.cassandra.locator.NetworkTopologyStrategy
>   Durable Writes: true
>     Options: [datacenter1:1]
>   Column Families:
> PS: I looked in the tests of the CLI code of CASSANDRA-2683 and saw that the feature actually is not properly tested: the flag is set, but never tested.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (CASSANDRA-2907) durable_writes flag cannot be changed via the CLI (system does not process KsDef.durable_writes option properly).

Posted by "Pavel Yaskevich (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CASSANDRA-2907?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Pavel Yaskevich updated CASSANDRA-2907:
---------------------------------------

    Summary: durable_writes flag cannot be changed via the CLI (system does not process KsDef.durable_writes option properly).  (was: durable_writes flag cannot be changes via the CLI)

> durable_writes flag cannot be changed via the CLI (system does not process KsDef.durable_writes option properly).
> -----------------------------------------------------------------------------------------------------------------
>
>                 Key: CASSANDRA-2907
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-2907
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Tools
>    Affects Versions: 0.8.1
>            Reporter: Benjamin Schrauwen
>            Assignee: Pavel Yaskevich
>            Priority: Minor
>
> I am unable to change the durable_writes option in the CLI. Here are the commands to replicate the problem on a clean install:
> create keyspace test;
> update keyspace test with durable_writes=false;
> show keyspaces;
> It will still say:
> Keyspace: test:
>   Replication Strategy: org.apache.cassandra.locator.NetworkTopologyStrategy
>   Durable Writes: true
>     Options: [datacenter1:1]
>   Column Families:
> PS: I looked in the tests of the CLI code of CASSANDRA-2683 and saw that the feature actually is not properly tested: the flag is set, but never tested.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Assigned] (CASSANDRA-2907) durable_writes flag cannot be changes via the CLI

Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CASSANDRA-2907?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jonathan Ellis reassigned CASSANDRA-2907:
-----------------------------------------

    Assignee: Pavel Yaskevich

> durable_writes flag cannot be changes via the CLI
> -------------------------------------------------
>
>                 Key: CASSANDRA-2907
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-2907
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Tools
>    Affects Versions: 0.8.1
>            Reporter: Benjamin Schrauwen
>            Assignee: Pavel Yaskevich
>
> I am unable to change the durable_writes option in the CLI. Here are the commands to replicate the problem on a clean install:
> create keyspace test;
> update keyspace test with durable_writes=false;
> show keyspaces;
> It will still say:
> Keyspace: test:
>   Replication Strategy: org.apache.cassandra.locator.NetworkTopologyStrategy
>   Durable Writes: true
>     Options: [datacenter1:1]
>   Column Families:
> PS: I looked in the tests of the CLI code of CASSANDRA-2683 and saw that the feature actually is not properly tested: the flag is set, but never tested.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (CASSANDRA-2907) durable_writes flag cannot be changed via the CLI (system does not process KsDef.durable_writes option properly).

Posted by "Pavel Yaskevich (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CASSANDRA-2907?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Pavel Yaskevich updated CASSANDRA-2907:
---------------------------------------

    Component/s:     (was: Tools)
                 Core
         Labels:   (was: Core)

> durable_writes flag cannot be changed via the CLI (system does not process KsDef.durable_writes option properly).
> -----------------------------------------------------------------------------------------------------------------
>
>                 Key: CASSANDRA-2907
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-2907
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Core
>    Affects Versions: 0.8.1
>            Reporter: Benjamin Schrauwen
>            Assignee: Pavel Yaskevich
>            Priority: Minor
>             Fix For: 0.8.2
>
>         Attachments: CASSANDRA-2907.patch
>
>
> I am unable to change the durable_writes option in the CLI. Here are the commands to replicate the problem on a clean install:
> create keyspace test;
> update keyspace test with durable_writes=false;
> show keyspaces;
> It will still say:
> Keyspace: test:
>   Replication Strategy: org.apache.cassandra.locator.NetworkTopologyStrategy
>   Durable Writes: true
>     Options: [datacenter1:1]
>   Column Families:
> PS: I looked in the tests of the CLI code of CASSANDRA-2683 and saw that the feature actually is not properly tested: the flag is set, but never tested.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (CASSANDRA-2907) durable_writes flag cannot be changes via the CLI

Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CASSANDRA-2907?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jonathan Ellis updated CASSANDRA-2907:
--------------------------------------

    Component/s:     (was: Core)
                 Tools
       Priority: Minor  (was: Major)

> durable_writes flag cannot be changes via the CLI
> -------------------------------------------------
>
>                 Key: CASSANDRA-2907
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-2907
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Tools
>    Affects Versions: 0.8.1
>            Reporter: Benjamin Schrauwen
>            Assignee: Pavel Yaskevich
>            Priority: Minor
>
> I am unable to change the durable_writes option in the CLI. Here are the commands to replicate the problem on a clean install:
> create keyspace test;
> update keyspace test with durable_writes=false;
> show keyspaces;
> It will still say:
> Keyspace: test:
>   Replication Strategy: org.apache.cassandra.locator.NetworkTopologyStrategy
>   Durable Writes: true
>     Options: [datacenter1:1]
>   Column Families:
> PS: I looked in the tests of the CLI code of CASSANDRA-2683 and saw that the feature actually is not properly tested: the flag is set, but never tested.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira