[GitHub] [maven-jar-plugin] rhowe commented on a diff in pull request #47: Code simplifications

[GitBox <gi...@apache.org>]

rhowe commented on code in PR #47:
URL: https://github.com/apache/maven-jar-plugin/pull/47#discussion_r942610239


##########
src/main/java/org/apache/maven/plugins/jar/AbstractJarMojo.java:
##########
@@ -196,16 +196,17 @@ protected File getJarFile( File basedir, String resultFinalName, String classifi
             throw new IllegalArgumentException( "finalName is not allowed to be null" );
         }
 
-        StringBuilder fileName = new StringBuilder( resultFinalName );
-
+        final String fileName;

Review Comment:
   No real need, it's mostly just syntactic sugar in this case. It's somewhat a statement of intent indicating that the value will be calculated only once.
   This was the kind of feedback I was seeking though - if you're happy with the changeset in principle, I'll take the `final`s out, cut a Jira ticket and make the PR more presentable etc.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org