You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2020/11/06 22:07:39 UTC

[GitHub] [beam] kw2542 commented on a change in pull request #13280: BEAM-11194: Add timer family id support in KeyedTimerData

kw2542 commented on a change in pull request #13280:
URL: https://github.com/apache/beam/pull/13280#discussion_r519029536



##########
File path: runners/samza/src/main/java/org/apache/beam/runners/samza/runtime/KeyedTimerData.java
##########
@@ -192,7 +193,10 @@ public void encode(KeyedTimerData<K> value, OutputStream outStream)
         keyBytes = baos.toByteArray();
       }
 
-      return new KeyedTimerData(keyBytes, key, timer);
+      final String timerFamilyId = inStream.available() > 0 ? STRING_CODER.decode(inStream) : "";

Review comment:
       I will add the comment when moving the recently added outputTimestamps field.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org