[GitHub] [spark] gatorsmile commented on a change in pull request #24721: [SPARK-27856][SQL] do not forcibly add cast when inserting table

[GitBox <gi...@apache.org>]

gatorsmile commented on a change in pull request #24721: [SPARK-27856][SQL] do not forcibly add cast when inserting table
URL: https://github.com/apache/spark/pull/24721#discussion_r288411977
 
 

 ##########
 File path: sql/core/src/main/scala/org/apache/spark/sql/internal/BaseSessionStateBuilder.scala
 ##########
 @@ -175,6 +175,7 @@ abstract class BaseSessionStateBuilder(
     override val postHocResolutionRules: Seq[Rule[LogicalPlan]] =
       PreprocessTableCreation(session) +:
         PreprocessTableInsertion(conf) +:
+        ResolveUpCast +:
 
 Review comment:
   Write a comment and explain this rule is to resolve the upcast added in PreprocessTableInsertion?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org