[GitHub] [incubator-superset] bradgessler commented on pull request #9183: forcing fixed width fonts on ace editor (fixes #9095)

[GitBox <gi...@apache.org>]

bradgessler commented on pull request #9183:
URL: https://github.com/apache/incubator-superset/pull/9183#issuecomment-624204443


   This doesn't fix the issue in 0.36.0. There's another CSS rule taking precedence (top) over these changes made by this patch (bottom):
   
   <img width="491" alt="Screen Shot 2020-05-05 at 10 39 53" src="https://user-images.githubusercontent.com/4628/81097430-c2b72600-8ebc-11ea-811f-a8e0c9549c13.png">
   
   The `font-family` attribute on the bottom should be the rule that is applied, but the `font` attribute from the `.ace_editor` class up top is taking precedence. When I disable the rule that's taking precedence, the editor works correctly.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org