[GitHub] [spark] HyukjinKwon commented on a change in pull request #33816: [WIP][SPARK-36567][SQL] Support foldable special datetime strings by `CAST`

[GitBox <gi...@apache.org>]

HyukjinKwon commented on a change in pull request #33816:
URL: https://github.com/apache/spark/pull/33816#discussion_r694445672



##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/finishAnalysis.scala
##########
@@ -119,3 +120,25 @@ case class ReplaceCurrentLike(catalogManager: CatalogManager) extends Rule[Logic
     }
   }
 }
+
+/**
+ * Replaces casts of special datetime strings by its date/timestamp values
+ * if the input strings are foldable.

Review comment:
       Should this be placed under constant folding? cc @cloud-fan




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org