You are viewing a plain text version of this content. The canonical link for it is here.
Posted to fop-dev@xmlgraphics.apache.org by bu...@apache.org on 2010/12/16 13:15:37 UTC

DO NOT REPLY [Bug 50483] New: [PATCH] Full font embedding and Subset embedding in Post Script

https://issues.apache.org/bugzilla/show_bug.cgi?id=50483

           Summary: [PATCH] Full font embedding and Subset embedding in
                    Post Script
           Product: Fop
           Version: all
          Platform: PC
        OS/Version: Linux
            Status: NEW
          Severity: normal
          Priority: P2
         Component: fonts
        AssignedTo: fop-dev@xmlgraphics.apache.org
        ReportedBy: med1985@gmail.com


Created an attachment (id=26414)
 --> (https://issues.apache.org/bugzilla/attachment.cgi?id=26414)
Full and Subset embedding patch

This patch is for the Temp_TrueTypeInPostScript branch and contains the
following:
* support for full font embedding using /sfnts
* support for subset font embedding using /sfnts
* bugfixes to the o.a.f.fonts.truetype package
* JUnit tests for all classes created
* JUnit tests for some of o.a.f.fonts.truetype classes
* added Mockito test for state and behavioural class testing with JUnit

The Mockito jar can be found at:
http://mockito.org/

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

DO NOT REPLY [Bug 50483] [PATCH] Full font embedding and Subset embedding in Post Script

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=50483

Mehdi Houshmand <me...@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #26517|0                           |1
        is obsolete|                            |

--- Comment #8 from Mehdi Houshmand <me...@gmail.com> 2011-01-31 09:16:47 EST ---
Created an attachment (id=26580)
 --> (https://issues.apache.org/bugzilla/attachment.cgi?id=26580)
Bug Fix` to previous patch

BugFix:
1) PSPainter was writing endofline escape chars for multibyte characters (which
don't use ASCII hex string)
2) PSPainter was writing the endofline escape char when number of chars in
string were exactly 80 i.e. "<blah blah blah>\" instead of "<blah blah \ blah>"
i.e. the escape character "\" was without the ASCII hex string

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

DO NOT REPLY [Bug 50483] [PATCH] Full font embedding and Subset embedding in Post Script

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=50483

Mehdi Houshmand <me...@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #26414|0                           |1
        is obsolete|                            |

--- Comment #3 from Mehdi Houshmand <me...@gmail.com> 2010-12-24 03:55:17 EST ---
(From update of attachment 26414)
this has been replaced

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

DO NOT REPLY [Bug 50483] [PATCH] Full font embedding and Subset embedding in Post Script

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=50483

Mehdi Houshmand <me...@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

--- Comment #14 from Mehdi Houshmand <me...@gmail.com> 2012-04-08 09:22:29 UTC ---
Patch applied to r1307574

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

DO NOT REPLY [Bug 50483] [PATCH] Full font embedding and Subset embedding in Post Script

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=50483

--- Comment #4 from Mehdi Houshmand <me...@gmail.com> 2011-01-12 11:33:31 EST ---
Created an attachment (id=26484)
 --> (https://issues.apache.org/bugzilla/attachment.cgi?id=26484)
Full & Subset font embedding tests and code improvements

Fixed a bug when copying the hhea table.
Code improvement in TTFTableName

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

DO NOT REPLY [Bug 50483] [PATCH] Full font embedding and Subset embedding in Post Script

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=50483

Glenn Adams <gl...@skynav.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Priority|P3                          |P2

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

DO NOT REPLY [Bug 50483] [PATCH] Full font embedding and Subset embedding in Post Script

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=50483

Mehdi Houshmand <me...@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #26597|0                           |1
        is obsolete|                            |

--- Comment #10 from Mehdi Houshmand <me...@gmail.com> 2011-02-10 11:41:34 EST ---
Created an attachment (id=26632)
 --> (https://issues.apache.org/bugzilla/attachment.cgi?id=26632)
Patch

Reverted changes to PSPainter (regression issue).

Fixed lines > 255 chars without changing PSPainter very much

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

DO NOT REPLY [Bug 50483] [PATCH] Full font embedding and Subset embedding in Post Script

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=50483

Mehdi Houshmand <me...@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #26484|0                           |1
        is obsolete|                            |

--- Comment #6 from Mehdi Houshmand <me...@gmail.com> 2011-01-18 04:40:29 EST ---
Created an attachment (id=26504)
 --> (https://issues.apache.org/bugzilla/attachment.cgi?id=26504)
Bug Fixes to previous patch

Bug Fixes:
Bug in the "hhea" table - wasn't updating the number of horizontal metrics
Bug in directory table - wasn't writing the correct number of tables
Bug in post table - size of the post table was wrong

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

DO NOT REPLY [Bug 50483] [PATCH] Full font embedding and Subset embedding in Post Script

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=50483

Mehdi Houshmand <me...@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #26632|0                           |1
        is obsolete|                            |

--- Comment #11 from Mehdi Houshmand <me...@gmail.com> 2011-03-10 10:36:41 EST ---
Created an attachment (id=26760)
 --> (https://issues.apache.org/bugzilla/attachment.cgi?id=26760)
More bug fixes

Bugfixes:
EOF when reading a string at the end of a font file
NullPointerException when setting encoding-mode="single-byte" to PS format

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

DO NOT REPLY [Bug 50483] [PATCH] Full font embedding and Subset embedding in Post Script

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=50483

Andreas L. Delmelle <ad...@apache.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |50723

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

DO NOT REPLY [Bug 50483] [PATCH] Full font embedding and Subset embedding in Post Script

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=50483

Glenn Adams <gl...@skynav.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Priority|P2                          |P3

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

DO NOT REPLY [Bug 50483] [PATCH] Full font embedding and Subset embedding in Post Script

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=50483

Mehdi Houshmand <me...@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #26580|0                           |1
        is obsolete|                            |

--- Comment #9 from Mehdi Houshmand <me...@gmail.com> 2011-02-02 10:04:13 EST ---
Created an attachment (id=26597)
 --> (https://issues.apache.org/bugzilla/attachment.cgi?id=26597)
Another patch

Bugfix:
This replaces the previous issue and handles another use case i.e. the writing
of a hex string will also print an endline (and escape character) if it stops
on the 80th character. This is a boundary case.

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

DO NOT REPLY [Bug 50483] [PATCH] Full font embedding and Subset embedding in Post Script

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=50483

Mehdi Houshmand <me...@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #26504|0                           |1
        is obsolete|                            |

--- Comment #7 from Mehdi Houshmand <me...@gmail.com> 2011-01-19 11:11:04 EST ---
Created an attachment (id=26517)
 --> (https://issues.apache.org/bugzilla/attachment.cgi?id=26517)
More improvements

Bug Fixed - ConcurrentModificationException

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

DO NOT REPLY [Bug 50483] [PATCH] Full font embedding and Subset embedding in Post Script

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=50483

--- Comment #12 from Glenn Adams <gl...@skynav.com> 2012-04-07 01:45:10 UTC ---
resetting P2 open bugs to P3 pending further review

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

DO NOT REPLY [Bug 50483] [PATCH] Full font embedding and Subset embedding in Post Script

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=50483

--- Comment #1 from Mehdi Houshmand <me...@gmail.com> 2010-12-16 08:50:59 EST ---
If this patch is applied I'll amend the wiki, but in order to invoke full-font
embedding you need to add the embedding-mode attribute to the fop.xconf as
follows for DejaVuSans:

<font embed-url="truetype/ttf-dejavu/DejaVuSans.ttf" embedding-mode="full">
<font-triplet name="DejaVu Sans" style="normal" weight="normal"/>
</font>

for Subsetting you can either do as before:


<font embed-url="truetype/ttf-dejavu/DejaVuSans.ttf">
<font-triplet name="DejaVu Sans" style="normal" weight="normal"/>
</font>

or you can specify:

<font embed-url="truetype/ttf-dejavu/DejaVuSans.ttf" embedding-mode="subset">
<font-triplet name="DejaVu Sans" style="normal" weight="normal"/>
</font>

There is also embedding-mode="auto" which defaults to subsetting a font. Also,
for anyone interested, the reason /sfnts wasn't previously working was because
there were several bugs with the previous implementation (this patch fixes
them). The /sfnts process is perfectly valid and has worked with all the fonts
I have tested which include ASCII, CJK and Thai glyphs.

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

DO NOT REPLY [Bug 50483] [PATCH] Full font embedding and Subset embedding in Post Script

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=50483

--- Comment #2 from Mehdi Houshmand <me...@gmail.com> 2010-12-24 03:52:59 EST ---
Created an attachment (id=26446)
 --> (https://issues.apache.org/bugzilla/attachment.cgi?id=26446)
Full & Subset font embedding tests and code improvements

This patch replaces the previous patch that I uploaded and contains further
improvements, JUnit tests, and more bugfixes in PostScript and fonts.

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

DO NOT REPLY [Bug 50483] [PATCH] Full font embedding and Subset embedding in Post Script

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=50483

Mehdi Houshmand <me...@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #26446|0                           |1
        is obsolete|                            |

--- Comment #5 from Mehdi Houshmand <me...@gmail.com> 2011-01-12 11:34:07 EST ---
(From update of attachment 26446)
replaced

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

DO NOT REPLY [Bug 50483] [PATCH] Full font embedding and Subset embedding in Post Script

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=50483

--- Comment #13 from Glenn Adams <gl...@skynav.com> 2012-04-08 09:11:04 UTC ---
increase priority due to presence of a patch

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.