You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@age.apache.org by GitBox <gi...@apache.org> on 2022/12/23 08:28:57 UTC

[GitHub] [age] KamleshKumar427 opened a new pull request, #408: Changed volatility types of age_substring, age_left and age_right

KamleshKumar427 opened a new pull request, #408:
URL: https://github.com/apache/age/pull/408

   
   
   Changed volatility types of age_substring, age_left, and age_right to IMMUTABLE from STABLE. 
   Since these 3 functions are only performing operations on their inputs parameters and will provide the same result whenever the same parameters are passed. 
   They are neither looking up the database nor modifying the database anywhere in the definitions. Which makes these functions IMMUTABLE rather than STABLE.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@age.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [age] KamleshKumar427 commented on pull request #408: Changed volatility types of age_substring, age_left and age_right

Posted by GitBox <gi...@apache.org>.
KamleshKumar427 commented on PR #408:
URL: https://github.com/apache/age/pull/408#issuecomment-1364569311

   @jrgemignani you are Right!! I have mixed some statements while commenting. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@age.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [age] jrgemignani commented on pull request #408: Changed volatility types of age_substring, age_left and age_right

Posted by GitBox <gi...@apache.org>.
jrgemignani commented on PR #408:
URL: https://github.com/apache/age/pull/408#issuecomment-1364181679

   @KamleshKumar427 Your other assertions are correct, however, this one is not -
   
   > They are neither looking up the database nor modifying the database anywhere in the definitions. Which makes these functions IMMUTABLE rather than STABLE.
   
   You are conflating STABLE with VOLATILE. Please read https://www.postgresql.org/docs/current/xfunc-volatility.html


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@age.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [age] JoshInnis merged pull request #408: Changed volatility types of age_substring, age_left and age_right

Posted by GitBox <gi...@apache.org>.
JoshInnis merged PR #408:
URL: https://github.com/apache/age/pull/408


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@age.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org