You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2021/11/09 14:06:59 UTC

[GitHub] [skywalking] JohnNiang opened a new issue #8100: [Feature] [E2E-INFRA] Request to make kind file configuration expandable with system environment

JohnNiang opened a new issue #8100:
URL: https://github.com/apache/skywalking/issues/8100


   ### Search before asking
   
   - [X] I had searched in the [issues](https://github.com/apache/skywalking/issues?q=is%3Aissue) and found no similar feature requirement.
   
   
   ### Description
   
   Request to make kind file configuration expandable with system environment.
   
   ### Use case
   
   E2E configuration sample:
   
   ```yaml
   setup:
     env: kind
     file: common/kind-$K8S_VERSION.yaml
   ```
   
   And there are several kind configurations in common folder:
   
   ```bash
   common
   ├── kind-1.19.yaml
   ├── kind-1.20.yaml
   ├── kind-1.21.yaml
   └── kind-1.22.yaml
   ```
   
   Then, we could create a matrix E2E testing in GitHub Action, such as:
   
   ```yaml
   jobs:
     Install:
       name: XYZ
       runs-on: ubuntu-latest
       timeout-minutes: 60
       strategy:
         matrix:
           k8sVersion: ["1.19", "1.20", "1.21", "1.22"]
       steps:
         - uses: actions/checkout@v2
         - 
         - name: Run E2E Test
           uses: apache/skywalking-infra-e2e@feat/expand-env-for-kind-config-path
           env:
             K8S_VERSION: ${{ matrix.k8sVersion }}
           with:
             e2e-file: $GITHUB_WORKSPACE/test/e2e/cases/xyz/e2e.yaml
   ```
   
   ### Related issues
   
   _No response_
   
   ### Are you willing to submit a PR?
   
   - [X] Yes I am willing to submit a PR!
   
   ### Code of Conduct
   
   - [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] kezhenxu94 closed issue #8100: [Feature] [E2E-INFRA] Request to make kind file configuration expandable with system environment

Posted by GitBox <gi...@apache.org>.
kezhenxu94 closed issue #8100:
URL: https://github.com/apache/skywalking/issues/8100


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] wu-sheng commented on issue #8100: [Feature] [E2E-INFRA] Request to make kind file configuration expandable with system environment

Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #8100:
URL: https://github.com/apache/skywalking/issues/8100#issuecomment-964189880


   Assigned to you already. This seems reasonable when face multiple versions of k8s testings, like in KubeSphere cases.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org