[GitHub] [knox] lmccay commented on a change in pull request #442: KNOX-2598 - Added SSL connection support for PostgreSQL database type in JDBC token state management

[GitBox <gi...@apache.org>]

lmccay commented on a change in pull request #442:
URL: https://github.com/apache/knox/pull/442#discussion_r623865574



##########
File path: gateway-server/src/main/java/org/apache/knox/gateway/config/impl/GatewayConfigImpl.java
##########
@@ -1258,4 +1261,20 @@ public int getDatabasePort() {
   public String getDatabaseName() {
     return get(GATEWAY_DATABASE_NAME, "GATEWAY_DATABASE");
   }
+
+  @Override
+  public boolean isDatabaseSslEnabled() {

Review comment:
       So, it seems that we are assuming that we will only ever have one database - which likely makes perfect sense. This does however imply that either we will only have one JDBC TSS per deployment or that the schema will disambiguate which topology the tokens are associated with. This is something that we need to reconcile though not necessarily now.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org