You are viewing a plain text version of this content. The canonical link for it is here.
Posted to c-dev@axis.apache.org by "Frank Huebbers (JIRA)" <ji...@apache.org> on 2008/01/02 16:41:34 UTC

[jira] Created: (AXIS2C-864) Use of 'const' for arguments in setter methods of generated types

Use of 'const' for arguments in setter methods of generated types
-----------------------------------------------------------------

                 Key: AXIS2C-864
                 URL: https://issues.apache.org/jira/browse/AXIS2C-864
             Project: Axis2-C
          Issue Type: Improvement
    Affects Versions: Current (Nightly)
            Reporter: Frank Huebbers



In setter methods of the various types generated by the wsdl2c tool, I would like to see a const classifier on the inputs, especially in the case when the input is of type axis2_char_t. 

For example, for a LoginType I have a username which I can set. In the current version of the tool, the following prototype is generated:

axis2_status_t AXIS2_CALL
        adb_LoginType_set_username(
            adb_LoginType_t* _LoginType,
            const axutil_env_t *env,
            axis2_char_t*  arg_username);

What would be better, however, is the following:

axis2_status_t AXIS2_CALL
        adb_LoginType_set_username(
            adb_LoginType_t* _LoginType,
            const axutil_env_t *env,
            const axis2_char_t*  arg_username);

I generated the client stub with the following options on the wsdl2c tool: -uri myWSDL.wsdl -d adb -u

Thanks for all the help and time in advance.

Cheers,
Frank


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: axis-c-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: axis-c-dev-help@ws.apache.org


[jira] Commented: (AXIS2C-864) Use of 'const' for arguments in setter methods of generated types

Posted by "Frank Huebbers (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/AXIS2C-864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12555727#action_12555727 ] 

Frank Huebbers commented on AXIS2C-864:
---------------------------------------

This is exactly what I need :)

Thanks a bunch for the quick fix!

Cheers,
Frank

> Use of 'const' for arguments in setter methods of generated types
> -----------------------------------------------------------------
>
>                 Key: AXIS2C-864
>                 URL: https://issues.apache.org/jira/browse/AXIS2C-864
>             Project: Axis2-C
>          Issue Type: Improvement
>          Components: wsdl2c tool
>    Affects Versions: Current (Nightly)
>            Reporter: Frank Huebbers
>
> In setter methods of the various types generated by the wsdl2c tool, I would like to see a const classifier on the inputs, especially in the case when the input is of type axis2_char_t. 
> For example, for a LoginType I have a username which I can set. In the current version of the tool, the following prototype is generated:
> axis2_status_t AXIS2_CALL
>         adb_LoginType_set_username(
>             adb_LoginType_t* _LoginType,
>             const axutil_env_t *env,
>             axis2_char_t*  arg_username);
> What would be better, however, is the following:
> axis2_status_t AXIS2_CALL
>         adb_LoginType_set_username(
>             adb_LoginType_t* _LoginType,
>             const axutil_env_t *env,
>             const axis2_char_t*  arg_username);
> I generated the client stub with the following options on the wsdl2c tool: -uri myWSDL.wsdl -d adb -u
> Thanks for all the help and time in advance.
> Cheers,
> Frank

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: axis-c-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: axis-c-dev-help@ws.apache.org


[jira] Closed: (AXIS2C-864) Use of 'const' for arguments in setter methods of generated types

Posted by "Frank Huebbers (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/AXIS2C-864?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Frank Huebbers closed AXIS2C-864.
---------------------------------


I tried this out with the January 7, 2008 snapshot and it works great for me now :)

Frank

> Use of 'const' for arguments in setter methods of generated types
> -----------------------------------------------------------------
>
>                 Key: AXIS2C-864
>                 URL: https://issues.apache.org/jira/browse/AXIS2C-864
>             Project: Axis2-C
>          Issue Type: Improvement
>          Components: wsdl2c tool
>    Affects Versions: Current (Nightly)
>            Reporter: Frank Huebbers
>
> In setter methods of the various types generated by the wsdl2c tool, I would like to see a const classifier on the inputs, especially in the case when the input is of type axis2_char_t. 
> For example, for a LoginType I have a username which I can set. In the current version of the tool, the following prototype is generated:
> axis2_status_t AXIS2_CALL
>         adb_LoginType_set_username(
>             adb_LoginType_t* _LoginType,
>             const axutil_env_t *env,
>             axis2_char_t*  arg_username);
> What would be better, however, is the following:
> axis2_status_t AXIS2_CALL
>         adb_LoginType_set_username(
>             adb_LoginType_t* _LoginType,
>             const axutil_env_t *env,
>             const axis2_char_t*  arg_username);
> I generated the client stub with the following options on the wsdl2c tool: -uri myWSDL.wsdl -d adb -u
> Thanks for all the help and time in advance.
> Cheers,
> Frank

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: axis-c-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: axis-c-dev-help@ws.apache.org


[jira] Resolved: (AXIS2C-864) Use of 'const' for arguments in setter methods of generated types

Posted by "Dimuthu Gamage (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/AXIS2C-864?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Dimuthu Gamage resolved AXIS2C-864.
-----------------------------------

    Resolution: Fixed

We are now declaring arguments const in setters when types are primitive or axis2_char_t*,
We can't use const for other argument types since we are actually modifying those values (, like freeing)  inside the generated code.

> Use of 'const' for arguments in setter methods of generated types
> -----------------------------------------------------------------
>
>                 Key: AXIS2C-864
>                 URL: https://issues.apache.org/jira/browse/AXIS2C-864
>             Project: Axis2-C
>          Issue Type: Improvement
>          Components: wsdl2c tool
>    Affects Versions: Current (Nightly)
>            Reporter: Frank Huebbers
>
> In setter methods of the various types generated by the wsdl2c tool, I would like to see a const classifier on the inputs, especially in the case when the input is of type axis2_char_t. 
> For example, for a LoginType I have a username which I can set. In the current version of the tool, the following prototype is generated:
> axis2_status_t AXIS2_CALL
>         adb_LoginType_set_username(
>             adb_LoginType_t* _LoginType,
>             const axutil_env_t *env,
>             axis2_char_t*  arg_username);
> What would be better, however, is the following:
> axis2_status_t AXIS2_CALL
>         adb_LoginType_set_username(
>             adb_LoginType_t* _LoginType,
>             const axutil_env_t *env,
>             const axis2_char_t*  arg_username);
> I generated the client stub with the following options on the wsdl2c tool: -uri myWSDL.wsdl -d adb -u
> Thanks for all the help and time in advance.
> Cheers,
> Frank

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: axis-c-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: axis-c-dev-help@ws.apache.org


[jira] Updated: (AXIS2C-864) Use of 'const' for arguments in setter methods of generated types

Posted by "Frank Huebbers (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/AXIS2C-864?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Frank Huebbers updated AXIS2C-864:
----------------------------------

    Component/s: wsdl2c tool

> Use of 'const' for arguments in setter methods of generated types
> -----------------------------------------------------------------
>
>                 Key: AXIS2C-864
>                 URL: https://issues.apache.org/jira/browse/AXIS2C-864
>             Project: Axis2-C
>          Issue Type: Improvement
>          Components: wsdl2c tool
>    Affects Versions: Current (Nightly)
>            Reporter: Frank Huebbers
>
> In setter methods of the various types generated by the wsdl2c tool, I would like to see a const classifier on the inputs, especially in the case when the input is of type axis2_char_t. 
> For example, for a LoginType I have a username which I can set. In the current version of the tool, the following prototype is generated:
> axis2_status_t AXIS2_CALL
>         adb_LoginType_set_username(
>             adb_LoginType_t* _LoginType,
>             const axutil_env_t *env,
>             axis2_char_t*  arg_username);
> What would be better, however, is the following:
> axis2_status_t AXIS2_CALL
>         adb_LoginType_set_username(
>             adb_LoginType_t* _LoginType,
>             const axutil_env_t *env,
>             const axis2_char_t*  arg_username);
> I generated the client stub with the following options on the wsdl2c tool: -uri myWSDL.wsdl -d adb -u
> Thanks for all the help and time in advance.
> Cheers,
> Frank

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: axis-c-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: axis-c-dev-help@ws.apache.org