[GitHub] [logging-log4net] fluffynuts commented on pull request #67: Add FxCop.

[GitBox <gi...@apache.org>]

fluffynuts commented on pull request #67:
URL: https://github.com/apache/logging-log4net/pull/67#issuecomment-693981771


   @NicholasNoise I'm all for trying to up code quality; this adds a _ton_ of noise though. For me, warnings are a thing that should not be seen -- all warnings should be attended to, either by solving the problem the warning is about or by intentionally suppressing the warning. Perhaps FxCop isn't the way to go? Perhaps we should look at something like SonarQube? It's equally noisy, but not in the build.
   The problem with a sea of warnings is that no-one will deal with them, and they drown out potentially problematic stuff. For instance, you've fixed up a place where a StreamWriter wasn't disposed (good!), but how would I spot that in all of this if you hadn't? I _really want_ all the fixes for stuff which hasn't been disposed, but I'm a little overwhelmed by the new warning noise.
   
   Also, FYI, `npm run build` fails: 
   ```
   Util\PropertiesDictionary.cs(39,22): error CA2237: Add [Serializable] to PropertiesDictionary as this type implements ISerializable [C:\code\opensource\log4net\src\log4net\log4net.csproj]
   ```
   Took me a while to find it in the swathes of warnings.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org