You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by "rodcloutier (via GitHub)" <gi...@apache.org> on 2024/01/25 16:13:35 UTC
[PR] Allow to use the Toolimage specified in the provided buildconfig [camel-k]
rodcloutier opened a new pull request, #5110:
URL: https://github.com/apache/camel-k/pull/5110
This PR proposed to honor the configurationBuild field that can be used to provide a custom builder image.
Currently we provide a field `ToolImage` that can be used to specify the image used by the builder. In the code, we specifically ignore the provided image and impose the operator image.
The proposed changes will only use the operator image if the `ToolImage` field is not specified.
In our current settings, it is actually the same behaviour that was expressed: we use the operator image as the `ToolImage` field.
We could also deprecate the `ToolImage` field to express that the usage will not be honoured.
**Release Note**
```release-note
NONE
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Allow to use the Toolimage specified in the provided buildconfig [camel-k]
Posted by "squakez (via GitHub)" <gi...@apache.org>.
squakez commented on PR #5110:
URL: https://github.com/apache/camel-k/pull/5110#issuecomment-1912117575
> Thanks for the insight. Could we then deprecate, and eventually remove, the `ToolImage` field in the BuildConfiguration? It seems, from my understanding, that there is no use for it.
>
> We explicitly assign the value as the operator image in one and only one place.
We can't. We don't know ahead of time which is the container/version the operator is running. With this design, we read it at runtime and make sure that it is always the same for which the operator is running.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Allow to use the Toolimage specified in the provided buildconfig [camel-k]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #5110:
URL: https://github.com/apache/camel-k/pull/5110#issuecomment-2078378825
This PR has been automatically marked as stale due to 90 days of inactivity.
It will be closed if no further activity occurs within 15 days.
If you think that’s incorrect or the issue should never stale, please simply write any comment.
Thanks for your contributions!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Allow to use the Toolimage specified in the provided buildconfig [camel-k]
Posted by "rodcloutier (via GitHub)" <gi...@apache.org>.
rodcloutier commented on PR #5110:
URL: https://github.com/apache/camel-k/pull/5110#issuecomment-1912021262
Thanks for the insight. Could we then deprecate, and eventually remove, the `ToolImage` field in the BuildConfiguration?
It seems, from my understanding, that there is no use for it.
We explicitly assign the value as the operator image in one and only one place.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Allow to use the Toolimage specified in the provided buildconfig [camel-k]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed pull request #5110: Allow to use the Toolimage specified in the provided buildconfig
URL: https://github.com/apache/camel-k/pull/5110
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org