You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2022/06/03 04:29:54 UTC
[GitHub] [incubator-nuttx] rtucker85 opened a new pull request, #6361: arch/risc-v: re-add missing riscv_udelay source
rtucker85 opened a new pull request, #6361:
URL: https://github.com/apache/incubator-nuttx/pull/6361
## Summary
Add back in riscv_udelay.c to the common riscv build.
This was removed in: 9d9d591b935ff00eba21473dbd52cdab4424342b
This is required in mmcsd_sdio.c for example.
## Impact
Regained successful builds when the mmc driver is enabled on a RISC-V system.
## Testing
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #6361: arch/risc-v: re-add missing riscv_udelay source
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 merged PR #6361:
URL: https://github.com/apache/incubator-nuttx/pull/6361
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] rtucker85 commented on a diff in pull request #6361: arch/risc-v: re-add missing riscv_udelay source
Posted by GitBox <gi...@apache.org>.
rtucker85 commented on code in PR #6361:
URL: https://github.com/apache/incubator-nuttx/pull/6361#discussion_r888655936
##########
arch/risc-v/src/common/Make.defs:
##########
@@ -32,7 +32,7 @@ CMN_CSRCS += riscv_assert.c riscv_blocktask.c riscv_copystate.c riscv_initialsta
CMN_CSRCS += riscv_modifyreg32.c riscv_mdelay.c riscv_puts.c
CMN_CSRCS += riscv_releasepending.c riscv_reprioritizertr.c
CMN_CSRCS += riscv_releasestack.c riscv_stackframe.c riscv_schedulesigaction.c
-CMN_CSRCS += riscv_sigdeliver.c riscv_unblocktask.c riscv_usestack.c
+CMN_CSRCS += riscv_sigdeliver.c riscv_udelay.c riscv_unblocktask.c riscv_usestack.c
Review Comment:
Done!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a diff in pull request #6361: arch/risc-v: re-add missing riscv_udelay source
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on code in PR #6361:
URL: https://github.com/apache/incubator-nuttx/pull/6361#discussion_r888607902
##########
arch/risc-v/src/common/Make.defs:
##########
@@ -32,7 +32,7 @@ CMN_CSRCS += riscv_assert.c riscv_blocktask.c riscv_copystate.c riscv_initialsta
CMN_CSRCS += riscv_modifyreg32.c riscv_mdelay.c riscv_puts.c
CMN_CSRCS += riscv_releasepending.c riscv_reprioritizertr.c
CMN_CSRCS += riscv_releasestack.c riscv_stackframe.c riscv_schedulesigaction.c
-CMN_CSRCS += riscv_sigdeliver.c riscv_unblocktask.c riscv_usestack.c
+CMN_CSRCS += riscv_sigdeliver.c riscv_udelay.c riscv_unblocktask.c riscv_usestack.c
Review Comment:
@rtucker85 need modify here like arm:
https://github.com/apache/incubator-nuttx/blob/master/arch/arm/src/common/Make.defs#L32-L36
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org