You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2021/10/12 04:13:18 UTC
[GitHub] [apisix-dashboard] zaunist opened a new pull request #2169: ci: add issue stale processor
zaunist opened a new pull request #2169:
URL: https://github.com/apache/apisix-dashboard/pull/2169
Please answer these questions before submitting a pull request, **or your PR will get closed**.
**Why submit this pull request?**
Add the automatic cleaning function of obsolete issue for the current repo
- [ ] Bugfix
- [ ] New feature provided
- [ x ] Improve performance
- [ ] Backport patches
**What changes will this PR take into?**
Add the automatic cleaning function of obsolete issue for the current repo
**Related issues**
resolve #2162
**Checklist:**
- [ x ] Did you explain what problem does this PR solve? Or what new features have been added?
- [ ] Have you added corresponding test cases?
- [ ] Have you modified the corresponding document?
- [ x ] Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on a change in pull request #2169: ci: add issue stale processor
Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on a change in pull request #2169:
URL: https://github.com/apache/apisix-dashboard/pull/2169#discussion_r727687928
##########
File path: .github/workflows/stale.yml
##########
@@ -0,0 +1,46 @@
+on:
+ workflow_dispatch:
+ schedule:
+ - cron: '0 10 * * *'
+
+jobs:
+ prune_stale:
+ name: Prune Stale
+ runs-on: ubuntu-latest
+
+ steps:
+ - name: Prune Stale
+ uses: actions/stale@v4.0.0
+ with:
+ days-before-issue-stale: 350
Review comment:
Actually, I'm not so sure how long it's appropriate 😂 For the Dashboard project, due to we don't have too much complicated work, how about using 21 days?
##########
File path: .github/workflows/stale.yml
##########
@@ -0,0 +1,46 @@
+on:
+ workflow_dispatch:
+ schedule:
+ - cron: '0 10 * * *'
+
+jobs:
+ prune_stale:
+ name: Prune Stale
+ runs-on: ubuntu-latest
+
+ steps:
+ - name: Prune Stale
+ uses: actions/stale@v4.0.0
+ with:
+ days-before-issue-stale: 350
Review comment:
+1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] zaunist commented on a change in pull request #2169: ci: add issue stale processor
Posted by GitBox <gi...@apache.org>.
zaunist commented on a change in pull request #2169:
URL: https://github.com/apache/apisix-dashboard/pull/2169#discussion_r727779264
##########
File path: .github/workflows/stale.yml
##########
@@ -0,0 +1,46 @@
+on:
+ workflow_dispatch:
+ schedule:
+ - cron: '0 10 * * *'
+
+jobs:
+ prune_stale:
+ name: Prune Stale
+ runs-on: ubuntu-latest
+
+ steps:
+ - name: Prune Stale
+ uses: actions/stale@v4.0.0
+ with:
+ days-before-issue-stale: 30
+ days-before-issue-close: 14
+ stale-issue-message: >
+ This issue has been marked as stale due to 350 days of inactivity.
Review comment:
😂Have synchronous
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] zaunist commented on pull request #2169: ci: add issue stale processor
Posted by GitBox <gi...@apache.org>.
zaunist commented on pull request #2169:
URL: https://github.com/apache/apisix-dashboard/pull/2169#issuecomment-941974829
@bzp2010 @juzhiyuan
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] bzp2010 commented on a change in pull request #2169: ci: add issue stale processor
Posted by GitBox <gi...@apache.org>.
bzp2010 commented on a change in pull request #2169:
URL: https://github.com/apache/apisix-dashboard/pull/2169#discussion_r727698311
##########
File path: .github/workflows/stale.yml
##########
@@ -0,0 +1,46 @@
+on:
+ workflow_dispatch:
+ schedule:
+ - cron: '0 10 * * *'
+
+jobs:
+ prune_stale:
+ name: Prune Stale
+ runs-on: ubuntu-latest
+
+ steps:
+ - name: Prune Stale
+ uses: actions/stale@v4.0.0
+ with:
+ days-before-issue-stale: 350
Review comment:
Maybe you can take a whole month up. How about 30 days?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] bzp2010 commented on pull request #2169: ci: add issue stale processor
Posted by GitBox <gi...@apache.org>.
bzp2010 commented on pull request #2169:
URL: https://github.com/apache/apisix-dashboard/pull/2169#issuecomment-940888271
Hi, @zaunist. Please check yaml file syntax. The CI syntax checker pointed out some problems.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] zaunist commented on pull request #2169: ci: add issue stale processor
Posted by GitBox <gi...@apache.org>.
zaunist commented on pull request #2169:
URL: https://github.com/apache/apisix-dashboard/pull/2169#issuecomment-940928604
> Hi, @zaunist. Please check yaml file syntax. The CI syntax checker pointed out some problems.
Hi, @bzp2010 . I have fixed the yaml lint problem, please review again
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] zaunist commented on a change in pull request #2169: ci: add issue stale processor
Posted by GitBox <gi...@apache.org>.
zaunist commented on a change in pull request #2169:
URL: https://github.com/apache/apisix-dashboard/pull/2169#discussion_r727704696
##########
File path: .github/workflows/stale.yml
##########
@@ -0,0 +1,46 @@
+on:
+ workflow_dispatch:
+ schedule:
+ - cron: '0 10 * * *'
+
+jobs:
+ prune_stale:
+ name: Prune Stale
+ runs-on: ubuntu-latest
+
+ steps:
+ - name: Prune Stale
+ uses: actions/stale@v4.0.0
+ with:
+ days-before-issue-stale: 350
Review comment:
30 days +1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on a change in pull request #2169: ci: add issue stale processor
Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on a change in pull request #2169:
URL: https://github.com/apache/apisix-dashboard/pull/2169#discussion_r727710414
##########
File path: .github/workflows/stale.yml
##########
@@ -0,0 +1,46 @@
+on:
+ workflow_dispatch:
+ schedule:
+ - cron: '0 10 * * *'
+
+jobs:
+ prune_stale:
+ name: Prune Stale
+ runs-on: ubuntu-latest
+
+ steps:
+ - name: Prune Stale
+ uses: actions/stale@v4.0.0
+ with:
+ days-before-issue-stale: 350
Review comment:
+1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] bzp2010 commented on a change in pull request #2169: ci: add issue stale processor
Posted by GitBox <gi...@apache.org>.
bzp2010 commented on a change in pull request #2169:
URL: https://github.com/apache/apisix-dashboard/pull/2169#discussion_r727766547
##########
File path: .github/workflows/stale.yml
##########
@@ -0,0 +1,46 @@
+on:
+ workflow_dispatch:
+ schedule:
+ - cron: '0 10 * * *'
+
+jobs:
+ prune_stale:
+ name: Prune Stale
+ runs-on: ubuntu-latest
+
+ steps:
+ - name: Prune Stale
+ uses: actions/stale@v4.0.0
+ with:
+ days-before-issue-stale: 30
+ days-before-issue-close: 14
+ stale-issue-message: >
+ This issue has been marked as stale due to 350 days of inactivity.
Review comment:
@zaunist Please modify here synchronously.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] bzp2010 commented on a change in pull request #2169: ci: add issue stale processor
Posted by GitBox <gi...@apache.org>.
bzp2010 commented on a change in pull request #2169:
URL: https://github.com/apache/apisix-dashboard/pull/2169#discussion_r727679060
##########
File path: .github/workflows/stale.yml
##########
@@ -0,0 +1,46 @@
+on:
+ workflow_dispatch:
+ schedule:
+ - cron: '0 10 * * *'
+
+jobs:
+ prune_stale:
+ name: Prune Stale
+ runs-on: ubuntu-latest
+
+ steps:
+ - name: Prune Stale
+ uses: actions/stale@v4.0.0
+ with:
+ days-before-issue-stale: 350
Review comment:
@juzhiyuan Do we need such a long expiration time? 🤔
##########
File path: .github/workflows/stale.yml
##########
@@ -0,0 +1,46 @@
+on:
+ workflow_dispatch:
+ schedule:
+ - cron: '0 10 * * *'
+
+jobs:
+ prune_stale:
+ name: Prune Stale
+ runs-on: ubuntu-latest
+
+ steps:
+ - name: Prune Stale
+ uses: actions/stale@v4.0.0
+ with:
+ days-before-issue-stale: 350
Review comment:
Maybe you can take a whole month up. How about 30 days?
##########
File path: .github/workflows/stale.yml
##########
@@ -0,0 +1,46 @@
+on:
+ workflow_dispatch:
+ schedule:
+ - cron: '0 10 * * *'
+
+jobs:
+ prune_stale:
+ name: Prune Stale
+ runs-on: ubuntu-latest
+
+ steps:
+ - name: Prune Stale
+ uses: actions/stale@v4.0.0
+ with:
+ days-before-issue-stale: 30
+ days-before-issue-close: 14
+ stale-issue-message: >
+ This issue has been marked as stale due to 350 days of inactivity.
Review comment:
@zaunist Please modify here synchronously.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] zaunist commented on pull request #2169: ci: add issue stale processor
Posted by GitBox <gi...@apache.org>.
zaunist commented on pull request #2169:
URL: https://github.com/apache/apisix-dashboard/pull/2169#issuecomment-940641684
@bzp2010 @liuxiran
Any feedback appreciate, thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] zaunist commented on pull request #2169: ci: add issue stale processor
Posted by GitBox <gi...@apache.org>.
zaunist commented on pull request #2169:
URL: https://github.com/apache/apisix-dashboard/pull/2169#issuecomment-941974829
@bzp2010 @juzhiyuan
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] zaunist commented on a change in pull request #2169: ci: add issue stale processor
Posted by GitBox <gi...@apache.org>.
zaunist commented on a change in pull request #2169:
URL: https://github.com/apache/apisix-dashboard/pull/2169#discussion_r727680174
##########
File path: .github/workflows/stale.yml
##########
@@ -0,0 +1,46 @@
+on:
+ workflow_dispatch:
+ schedule:
+ - cron: '0 10 * * *'
+
+jobs:
+ prune_stale:
+ name: Prune Stale
+ runs-on: ubuntu-latest
+
+ steps:
+ - name: Prune Stale
+ uses: actions/stale@v4.0.0
+ with:
+ days-before-issue-stale: 350
Review comment:
> @juzhiyuan Do we need such a long expiration time? 🤔
I refer to the Apisix project for the expiration date, and I am not quite sure how long it is appropriate. Maybe it can be changed to 180 days or other time. Could you please give me some suggestions
##########
File path: .github/workflows/stale.yml
##########
@@ -0,0 +1,46 @@
+on:
+ workflow_dispatch:
+ schedule:
+ - cron: '0 10 * * *'
+
+jobs:
+ prune_stale:
+ name: Prune Stale
+ runs-on: ubuntu-latest
+
+ steps:
+ - name: Prune Stale
+ uses: actions/stale@v4.0.0
+ with:
+ days-before-issue-stale: 350
Review comment:
30 days +1
##########
File path: .github/workflows/stale.yml
##########
@@ -0,0 +1,46 @@
+on:
+ workflow_dispatch:
+ schedule:
+ - cron: '0 10 * * *'
+
+jobs:
+ prune_stale:
+ name: Prune Stale
+ runs-on: ubuntu-latest
+
+ steps:
+ - name: Prune Stale
+ uses: actions/stale@v4.0.0
+ with:
+ days-before-issue-stale: 30
+ days-before-issue-close: 14
+ stale-issue-message: >
+ This issue has been marked as stale due to 350 days of inactivity.
Review comment:
😂Have synchronous
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] bzp2010 commented on a change in pull request #2169: ci: add issue stale processor
Posted by GitBox <gi...@apache.org>.
bzp2010 commented on a change in pull request #2169:
URL: https://github.com/apache/apisix-dashboard/pull/2169#discussion_r727679060
##########
File path: .github/workflows/stale.yml
##########
@@ -0,0 +1,46 @@
+on:
+ workflow_dispatch:
+ schedule:
+ - cron: '0 10 * * *'
+
+jobs:
+ prune_stale:
+ name: Prune Stale
+ runs-on: ubuntu-latest
+
+ steps:
+ - name: Prune Stale
+ uses: actions/stale@v4.0.0
+ with:
+ days-before-issue-stale: 350
Review comment:
@juzhiyuan Do we need such a long expiration time? 🤔
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] bzp2010 merged pull request #2169: ci: add issue stale processor
Posted by GitBox <gi...@apache.org>.
bzp2010 merged pull request #2169:
URL: https://github.com/apache/apisix-dashboard/pull/2169
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on a change in pull request #2169: ci: add issue stale processor
Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on a change in pull request #2169:
URL: https://github.com/apache/apisix-dashboard/pull/2169#discussion_r727687928
##########
File path: .github/workflows/stale.yml
##########
@@ -0,0 +1,46 @@
+on:
+ workflow_dispatch:
+ schedule:
+ - cron: '0 10 * * *'
+
+jobs:
+ prune_stale:
+ name: Prune Stale
+ runs-on: ubuntu-latest
+
+ steps:
+ - name: Prune Stale
+ uses: actions/stale@v4.0.0
+ with:
+ days-before-issue-stale: 350
Review comment:
Actually, I'm not so sure how long it's appropriate 😂 For the Dashboard project, due to we don't have too much complicated work, how about using 21 days?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] zaunist commented on a change in pull request #2169: ci: add issue stale processor
Posted by GitBox <gi...@apache.org>.
zaunist commented on a change in pull request #2169:
URL: https://github.com/apache/apisix-dashboard/pull/2169#discussion_r727680174
##########
File path: .github/workflows/stale.yml
##########
@@ -0,0 +1,46 @@
+on:
+ workflow_dispatch:
+ schedule:
+ - cron: '0 10 * * *'
+
+jobs:
+ prune_stale:
+ name: Prune Stale
+ runs-on: ubuntu-latest
+
+ steps:
+ - name: Prune Stale
+ uses: actions/stale@v4.0.0
+ with:
+ days-before-issue-stale: 350
Review comment:
> @juzhiyuan Do we need such a long expiration time? 🤔
I refer to the Apisix project for the expiration date, and I am not quite sure how long it is appropriate. Maybe it can be changed to 180 days or other time. Could you please give me some suggestions
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org