You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@httpd.apache.org by "MATHIHALLI,MADHUSUDAN (HP-Cupertino,ex1)" <ma...@hp.com> on 2001/08/08 04:14:34 UTC
RE: cvs commit: httpd-2.0/modules/ssl ssl_engine_io.c
Hi Doug,
This portion of the code can infact be eliminated.. I tested it on
HPUX and it works - I can verify the same on Linux and let you know..
Thanks
-Madhu
-----Original Message-----
From: dougm@apache.org [mailto:dougm@apache.org]
Sent: Tuesday, August 07, 2001 7:11 PM
To: httpd-2.0-cvs@apache.org
Subject: cvs commit: httpd-2.0/modules/ssl ssl_engine_io.c
dougm 01/08/07 19:10:51
Modified: modules/ssl ssl_engine_io.c
Log:
drop a brace inside #if 0 so emacs can indent properly
Revision Changes Path
1.13 +3 -4 httpd-2.0/modules/ssl/ssl_engine_io.c
Index: ssl_engine_io.c
===================================================================
RCS file: /home/cvs/httpd-2.0/modules/ssl/ssl_engine_io.c,v
retrieving revision 1.12
retrieving revision 1.13
diff -u -r1.12 -r1.13
--- ssl_engine_io.c 2001/08/08 02:09:26 1.12
+++ ssl_engine_io.c 2001/08/08 02:10:51 1.13
@@ -193,7 +193,6 @@
}
assert (n > 0); /* XXX => Check if required */
#if 0 /* XXX */
- }
else if (n == 0)
done = 1;
else
@@ -228,9 +227,9 @@
ap_input_mode_t eMode = (eReadType == APR_BLOCK_READ)
? AP_MODE_BLOCKING : AP_MODE_NONBLOCKING;
-/* XXX : Errrr... bad way of doing things TBD */
-eReadType = APR_BLOCK_READ;
-eMode = AP_MODE_BLOCKING;
+ /* XXX : Errrr... bad way of doing things TBD */
+ eReadType = APR_BLOCK_READ;
+ eMode = AP_MODE_BLOCKING;
if(APR_BRIGADE_EMPTY(pRec->pbbInput)) {
ap_get_brigade(pRec->pInputFilter->next,pRec->pbbInput,eMode,readbytes);
RE: cvs commit: httpd-2.0/modules/ssl ssl_engine_io.c
Posted by Doug MacEachern <do...@covalent.net>.
On Tue, 7 Aug 2001, MATHIHALLI,MADHUSUDAN (HP-Cupertino,ex1) wrote:
> Hi Doug,
> This portion of the code can infact be eliminated.. I tested it on
> HPUX and it works - I can verify the same on Linux and let you know..
which, the #if 0 stuff or the 'Errr ... bad way' stuff or both? :)
> Thanks
> -Madhu
>
> -----Original Message-----
> From: dougm@apache.org [mailto:dougm@apache.org]
> Sent: Tuesday, August 07, 2001 7:11 PM
> To: httpd-2.0-cvs@apache.org
> Subject: cvs commit: httpd-2.0/modules/ssl ssl_engine_io.c
>
>
> dougm 01/08/07 19:10:51
>
> Modified: modules/ssl ssl_engine_io.c
> Log:
> drop a brace inside #if 0 so emacs can indent properly
>
> Revision Changes Path
> 1.13 +3 -4 httpd-2.0/modules/ssl/ssl_engine_io.c
>
> Index: ssl_engine_io.c
> ===================================================================
> RCS file: /home/cvs/httpd-2.0/modules/ssl/ssl_engine_io.c,v
> retrieving revision 1.12
> retrieving revision 1.13
> diff -u -r1.12 -r1.13
> --- ssl_engine_io.c 2001/08/08 02:09:26 1.12
> +++ ssl_engine_io.c 2001/08/08 02:10:51 1.13
> @@ -193,7 +193,6 @@
> }
> assert (n > 0); /* XXX => Check if required */
> #if 0 /* XXX */
> - }
> else if (n == 0)
> done = 1;
> else
> @@ -228,9 +227,9 @@
> ap_input_mode_t eMode = (eReadType == APR_BLOCK_READ)
> ? AP_MODE_BLOCKING : AP_MODE_NONBLOCKING;
>
> -/* XXX : Errrr... bad way of doing things TBD */
> -eReadType = APR_BLOCK_READ;
> -eMode = AP_MODE_BLOCKING;
> + /* XXX : Errrr... bad way of doing things TBD */
> + eReadType = APR_BLOCK_READ;
> + eMode = AP_MODE_BLOCKING;
>
> if(APR_BRIGADE_EMPTY(pRec->pbbInput)) {
>
> ap_get_brigade(pRec->pInputFilter->next,pRec->pbbInput,eMode,readbytes);
>
>
>
>