You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2021/03/12 12:47:06 UTC

[GitHub] [cloudstack] rhtyd commented on a change in pull request #4800: kvm: Do not set backing file format of DATADISK in vm start/migration

rhtyd commented on a change in pull request #4800:
URL: https://github.com/apache/cloudstack/pull/4800#discussion_r593146838



##########
File path: plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java
##########
@@ -4266,7 +4266,8 @@ public void setBackingFileFormat(String volPath) {
             Map<String, String> info = qemu.info(file);
             String backingFilePath = info.get(new String("backing_file"));
             String backingFileFormat = info.get(new String("backing_file_format"));
-            if (org.apache.commons.lang.StringUtils.isEmpty(backingFileFormat)) {
+            if (org.apache.commons.lang.StringUtils.isNotBlank(backingFilePath)
+                    && org.apache.commons.lang.StringUtils.isEmpty(backingFileFormat)) {

Review comment:
       What if the backing file format is not empty? 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org