You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/01/05 15:21:53 UTC

[GitHub] [airflow] potiuk commented on a change in pull request #13488: Introduces separate runtime provider schema

potiuk commented on a change in pull request #13488:
URL: https://github.com/apache/airflow/pull/13488#discussion_r551999206



##########
File path: MANIFEST.in
##########
@@ -32,7 +32,7 @@ global-exclude __pycache__  *.pyc
 include airflow/alembic.ini
 include airflow/api_connexion/openapi/v1.yaml
 include airflow/git_version
-include airflow/provider.yaml.schema.json
+include airflow/provider.runtime.yaml.schema.json

Review comment:
       I thought about it but I'd rather keep the name 'provider.yaml.schema.json` because all the IDE tools (and people matching them) would rather use provider.yaml.json.schema to edit provider.yaml. And in fact provider.yaml is already development-only. There are no provider.yaml files beside the development.
   
   But  this thought leads me to another, better naming. The `provider.runtime.yaml.schama.json' shoudl be renamed `provider_info.schema.json` . This would be 1-1 with the entry-point name and there should be no yaml, because there is no yaml whatsoever n provider_info entrypoint. 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org