[jira] [Commented] (RATIS-30) Provide a way to pass parameters to rpc implementations

["Jing Zhao (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/RATIS-30?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15893587#comment-15893587 ] 

Jing Zhao commented on RATIS-30:
--------------------------------

The patch looks good to me. Two minors:
# putNewServers(RaftPeerId, boolean) can be renamed to putNewServer.
# Do we want to change "RpcType#newFactory(RaftProperties)" to newFactory(RaftProperties, RaftParameters)?


> Provide a way to pass parameters to rpc implementations
> -------------------------------------------------------
>
>                 Key: RATIS-30
>                 URL: https://issues.apache.org/jira/browse/RATIS-30
>             Project: Ratis
>          Issue Type: Sub-task
>            Reporter: Tsz Wo Nicholas Sze
>            Assignee: Tsz Wo Nicholas Sze
>         Attachments: r30_20170301.patch
>
>
> In this JIRA, we address the following comment from [~jingzhao] in RATIS-28.
> {quote}
> We can consider use some other way for library users to pass extra configuration objects for their RPC engine (e.g., Hadoop Configuration) into the RPC factory. In this way we can get a neater API for RPC creation and avoid using an lazy initialization supplier in RaftServerImpl.
> {quote}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)