You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2019/11/05 07:45:55 UTC
[GitHub] [incubator-apisix] moonming commented on a change in pull request
#806: change: used `lua-resty-prometheus` which the API is simpler.
moonming commented on a change in pull request #806: change: used `lua-resty-prometheus` which the API is simpler.
URL: https://github.com/apache/incubator-apisix/pull/806#discussion_r342416889
##########
File path: lua/apisix/plugins/prometheus/exporter.lua
##########
@@ -14,7 +14,7 @@
-- See the License for the specific language governing permissions and
-- limitations under the License.
--
-local base_prometheus = require("nginx.prometheus")
+local base_prometheus = require("resty.prometheus")
Review comment:
what license of `lua-resty-prometheus`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services