[GitHub] [iceberg] fbocse commented on a change in pull request #1187: Add support to parallelise the execution of tasks of metadata and data files delete operations

[GitBox <gi...@apache.org>]

fbocse commented on a change in pull request #1187:
URL: https://github.com/apache/iceberg/pull/1187#discussion_r454257193



##########
File path: core/src/main/java/org/apache/iceberg/RemoveSnapshots.java
##########
@@ -60,12 +62,19 @@ public void accept(String file) {
     }
   };
 
+  private final ExecutorService defaultDeleteExecutorService = Executors.newSingleThreadExecutor(runnable -> {

Review comment:
       Using `MoreExecutors.newDirectExecutorService()` to keep it consistent with the expected type `java.util.concurrent.ExecutorService` to pass to `org.apache.iceberg.util.Tasks.Builder#executeWith`




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org