You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2022/08/11 22:47:44 UTC

[GitHub] [beam] lostluck commented on issue #22704: [Feature Request]: [Go SDK] Encode Keys once for combiner lifting.

lostluck commented on issue #22704:
URL: https://github.com/apache/beam/issues/22704#issuecomment-1212568330

   A solution would be to encode to a []byte, wrap it in a bytes.Reader, then use that for the hash, and then the raw bytes for the byte by byte lookup comparison (as we do now). I'm not sure if we can change enough of the hash APIs to use byte.Reader directly keep everything stack based though.
   
   This would be good to have a benchmark written and then a Before/After comparison of the change (even if the benchmark is new with the PR) to validate.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org