[jira] Commented: (GERONIMO-5027) Redeploy option for farming

["Shawn Jiang (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/GERONIMO-5027?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12842585#action_12842585 ] 

Shawn Jiang commented on GERONIMO-5027:
---------------------------------------

Hi Ashish,

I tried your patch but it does not work, see following two error scenarios:


1, redeploy with the application and plan:


{noformat}
R:\farm_deploy\server0\bin>deploy redeploy --targets org.apache.geronimo.configs/farming/2.1.5-SNAPSHOT/car?ServiceModule=org.apache.geronimo.configs/farming/2.1.5-SNAPSHOT/car,j2eeType=ConfigurationStore,name=MasterConfigurationStore ../..
/servlet-examples-cluster-server0.war ../../servlet-examples-cluster-plan0.xml
Using GERONIMO_HOME:   R:\farm_deploy\server0
Using GERONIMO_TMPDIR: var\temp
Using JRE_HOME:        D:\dev\JDKs\sun_jdk6\jre
    No ModuleID or TargetModuleID provided.  Attempting to guess based
    on the content of the archive.
    Unable to locate Geronimo deployment plan in archive.  Calculating
    default ModuleID from archive name.
    Attempting to use ModuleID
    'default/servlet-examples-cluster-server0_G_MASTER//'
2010-03-08 16:39:49,047 ERROR [DeployTool] Error:
org.apache.geronimo.common.DeploymentException: default/servlet-examples-cluster-server0_G_MASTER// does not appear to be a the name of a module available on the selected server. Perhaps it has already been stopped or undeployed?  If you're
 trying to specify a TargetModuleID, use the syntax TargetName|ModuleName instead. If you're not sure what's running, try the list-modules command.
        at org.apache.geronimo.deployment.plugin.ConfigIDExtractor.identifyTargetModuleIDs(ConfigIDExtractor.java:205)
        at org.apache.geronimo.deployment.cli.CommandRedeploy.guessModuleId(CommandRedeploy.java:107)
        at org.apache.geronimo.deployment.cli.CommandRedeploy.execute(CommandRedeploy.java:181)
        at org.apache.geronimo.deployment.cli.DeployTool.execute(DeployTool.java:171)
        at org.apache.geronimo.kernel.util.MainConfigurationBootstrapper.main(MainConfigurationBootstrapper.java:45)
        at org.apache.geronimo.cli.AbstractCLI.executeMain(AbstractCLI.java:67)
        at org.apache.geronimo.cli.deployer.DeployerCLI.main(DeployerCLI.java:31)

{noformat}

default/servlet-examples-cluster-server0_G_MASTER// was caculated by mistake.  It should be  samples/servlet-examples-cluster-server1_G_MASTER/2.2/war



2, redeploy with the moduleId directly:
{noformat}
R:\farm_deploy\server0\bin>deploy list-modules  org.apache.geronimo.configs/farming/2.1.5-SNAPSHOT/car?ServiceModule=org.apache.geronimo.configs/farming/2.1.5-SNAPSHOT/car,j2eeType=ConfigurationStore,name=MasterConfigurationStore
Using GERONIMO_HOME:   R:\farm_deploy\server0
Using GERONIMO_TMPDIR: var\temp
Using JRE_HOME:        D:\dev\JDKs\sun_jdk6\jre
Found 1 module
  + samples/servlet-examples-cluster-server1_G_MASTER/2.2/war


R:\farm_deploy\server0\bin>deploy redeploy --targets org.apache.geronimo.configs/farming/2.1.5-SNAPSHOT/car?ServiceModule=org.apache.geronimo.configs/farming/2.1.5-SNAPSHOT/car,j2eeType=ConfigurationStore,name=MasterConfigurationStore sampl
es/servlet-examples-cluster-server1_G_MASTER/2.2/war
Using GERONIMO_HOME:   R:\farm_deploy\server0
Using GERONIMO_TMPDIR: var\temp
Using JRE_HOME:        D:\dev\JDKs\sun_jdk6\jre
2010-03-08 16:36:56,937 ERROR [DeployTool] Error:
org.apache.geronimo.deployment.cli.DeploymentSyntaxException: Module or plan file does not exist: R:\farm_deploy\server0\bin\samples\servlet-examples-cluster-server1_G_MASTER\2.2\war
        at org.apache.geronimo.deployment.cli.CommandRedeploy.checkFirstArguement(CommandRedeploy.java:53)
        at org.apache.geronimo.deployment.cli.CommandRedeploy.execute(CommandRedeploy.java:150)
        at org.apache.geronimo.deployment.cli.DeployTool.execute(DeployTool.java:171)
        at org.apache.geronimo.kernel.util.MainConfigurationBootstrapper.main(MainConfigurationBootstrapper.java:45)
        at org.apache.geronimo.cli.AbstractCLI.executeMain(AbstractCLI.java:67)
        at org.apache.geronimo.cli.deployer.DeployerCLI.main(DeployerCLI.java:31)
{noformat}



-------------------------------------------------------------------------------------------------------------------------------------------------------------------

The results above indicate the patch you upload need to rework.    I also found two obvious possible problems in the patch:


1,  if(args.length>=3 && args[0].equalsIgnoreCase("--targets")) //case of cluster redeployment
+            {

The lines above hard coded the --targets as the first args, If the user put the --targets in different sequence, the command will fail.


2, The gshell equivalence does not get updated to pull in the new command options so that your new farm redeploy will definitely not work in gshell.
The corresponding file should be 
framework\modules\geronimo-commands\src\main\groovy\org\apache\geronimo\commands\DeployModuleCommand.groovy



> Redeploy option for farming
> ---------------------------
>
>                 Key: GERONIMO-5027
>                 URL: https://issues.apache.org/jira/browse/GERONIMO-5027
>             Project: Geronimo
>          Issue Type: New Feature
>      Security Level: public(Regular issues) 
>          Components: Clustering
>    Affects Versions: 2.1.4, 2.2
>         Environment: Windows XP g214
>            Reporter: Ashish Jain
>            Assignee: Ashish Jain
>             Fix For: 2.1.5, 2.2.1
>
>         Attachments: 5027_21.patch
>
>
> Redeploy feature for farming.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.