You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Toby Johnson <to...@etjohnson.us> on 2006/06/21 04:54:48 UTC

Re: Agggh! 64-bit bug still present in 1.3.2 [PATCH]

David Summers wrote:
>
> On Mon, 5 Jun 2006, Toby Johnson wrote:
>
>> Nico Kadel-Garcia wrote:
>>> My latest patch is at:
>>>
>>>    
>>> http://subversion.tigris.org/nonav/issues/showattachment.cgi/558/x86_64.patch 
>>
>>
>> Nico, as long as we're replacing hardcoded paths with built-in 
>> rpmbuild macros, shouldn't the following substitutions also be made?
>>
>> /usr/bin => %{_bindir}
>> /usr/include => %{_includedir}
>> /usr/share/man => %{_mandir}
>> /usr/share => %{_datadir}
>>
>
> If someone could try the latest trunk and see if my /usr/bin -> 
> %{_bindir}
> and /usr/lib -> %{_libdir} has helped 64-bit users at all and let me 
> know, it would be appreciated.
>
> I still don't have a 64-bit system but I will soon order one (yay, 
> more toys) so hopefully soon I'll be able to verify this stuff.
>
> Until then, I either need feedback from someone else or if someone 
> could offer a login on a 64-bit system for a while that would be 
> appreciated.
>
> If we can get a clean 64-bit RPM build on trunk then we can back-port 
> to 1.4.x and/or 1.3.x.
>

Hello David, I finished running without checks enabled on 64-bit 
CentOS-4 and hit a couple snags, which the attached patch corrects (just 
a couple more missed /usr/lib64 locations). I'm assuming the patch 
can/should be applied for the other distros as well but I currently have 
no means of testing those.

The Makefile for building the RPMs still doesn't work, due to the 
hardcoded 32-bit paths in there, but I'm not really worried about 
that... it makes it up to and including creation of the RPMs anyway.

I'll run again with full tests and let you know if I find anything else.

toby

Re: Agggh! 64-bit bug still present in 1.3.2 [PATCH]

Posted by Marcus Rueckert <da...@web.de>.
On 2006-06-22 08:53:24 -0500, David Summers wrote:
> OK, that patch fails when I applied it to a 32-bit system so we need
> an %ifarch statement there.  If you could do that and try it out and if it 
> works send that patch or tonight I can try to do that and send it to you 
> and then you could try it out and let me know.  Either way is fine.  If I 
> don't hear from you then I'll try to generate that tonight and send it 
> out.

that sounds ugly. shouldnt those %{_*dir} macros save you from ifarch?

darix

-- 
           openSUSE - SUSE Linux is my linux
               openSUSE is good for you
                   www.opensuse.org

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Re: Agggh! 64-bit bug still present in 1.3.2 [PATCH]

Posted by David Summers <da...@summersoft.fay.ar.us>.
On Tue, 27 Jun 2006, Toby Johnson wrote:

> David Summers wrote:
>> Toby (and others),
>>   I commited these changes as of r20256.  Please check out trunk and 
>> compile it on 64-bit RHEL3/RHEL4 and let me know of any problems.  If you
>> can get a clean working build then let me know and I'll nominate the
>> changes in trunk for backport to 1.4.X and 1.3.X.
>
> Yes, I just did a build from trunk and it worked fine on x86_64/rhel-4.
>

Great!  I'll nominate the appropriate revisions for backport to 1.4.x and 
1.3.x.

   Thanks!
   - David

-- 
David Wayne Summers        "Linux: Because reboots are for hardware upgrades!"
david@summersoft.fay.ar.us PGP Key: http://summersoft.fay.ar.us/~david/pgp.txt
PGP Key fingerprint =  0B44 B118 85CC F4EC 7021  1ED4 1516 5B78 E320 2001

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Re: Agggh! 64-bit bug still present in 1.3.2 [PATCH]

Posted by Toby Johnson <to...@etjohnson.us>.
David Summers wrote:
> Toby (and others),
>   I commited these changes as of r20256.  Please check out trunk and 
> compile it on 64-bit RHEL3/RHEL4 and let me know of any problems.  If you
> can get a clean working build then let me know and I'll nominate the
> changes in trunk for backport to 1.4.X and 1.3.X.

Yes, I just did a build from trunk and it worked fine on x86_64/rhel-4.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Re: Agggh! 64-bit bug still present in 1.3.2 [PATCH]

Posted by David Summers <da...@summersoft.fay.ar.us>.
Toby (and others),
   I commited these changes as of r20256.  Please check out trunk and 
compile it on 64-bit RHEL3/RHEL4 and let me know of any problems.  If you
can get a clean working build then let me know and I'll nominate the
changes in trunk for backport to 1.4.X and 1.3.X.

     Thanks.
    - David Summers

On Sun, 25 Jun 2006, David Summers wrote:

> Date: Sun, 25 Jun 2006 22:28:41 -0500 (CDT)
> From: David Summers <da...@summersoft.fay.ar.us>
> Reply-To: David Summers <da...@summersoft.fay.ar.us>
> To: Toby Johnson <to...@etjohnson.us>
> Cc: Nico Kadel-Garcia <nk...@comcast.net>, dev <de...@subversion.tigris.org>
> Subject: Re: Agggh! 64-bit bug still present in 1.3.2 [PATCH]
> 
>
> On Thu, 22 Jun 2006, Toby Johnson wrote:
>
>> David Summers wrote:
>>> 
>>> OK, that patch fails when I applied it to a 32-bit system so we need
>>> an %ifarch statement there.  If you could do that and try it out and if it 
>>> works send that patch or tonight I can try to do that and send it to you 
>>> and then you could try it out and let me know.  Either way is fine.  If I 
>>> don't hear from you then I'll try to generate that tonight and send it 
>>> out.
>> Hi David,
>> 
>> I'll work on getting that added; can you specify which part of the patch 
>> causes the failure? (Or what the failure message is...)
>> 
>
> OK.  False alarm, sorry.  I must have done something wrong the first time I 
> applied the patch.  I just re-applied it and compiled on CentOS4 and 
> everything compiled correctly this time.  Wierd.
>
> I'll do some more testing and then commit it to trunk.  At that point we can 
> nominate it for back-port to 1.4.x and probably even 1.3.x.
>
> Thanks for the patch!
>
>

-- 
David Wayne Summers        "Linux: Because reboots are for hardware upgrades!"
david@summersoft.fay.ar.us PGP Key: http://summersoft.fay.ar.us/~david/pgp.txt
PGP Key fingerprint =  0B44 B118 85CC F4EC 7021  1ED4 1516 5B78 E320 2001

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Re: Agggh! 64-bit bug still present in 1.3.2 [PATCH]

Posted by David Summers <da...@summersoft.fay.ar.us>.
On Thu, 22 Jun 2006, Toby Johnson wrote:

> David Summers wrote:
>> 
>> OK, that patch fails when I applied it to a 32-bit system so we need
>> an %ifarch statement there.  If you could do that and try it out and if it 
>> works send that patch or tonight I can try to do that and send it to you 
>> and then you could try it out and let me know.  Either way is fine.  If I 
>> don't hear from you then I'll try to generate that tonight and send it out.
> Hi David,
>
> I'll work on getting that added; can you specify which part of the patch 
> causes the failure? (Or what the failure message is...)
>

OK.  False alarm, sorry.  I must have done something wrong the first time 
I applied the patch.  I just re-applied it and compiled on CentOS4 and 
everything compiled correctly this time.  Wierd.

I'll do some more testing and then commit it to trunk.  At that point we 
can nominate it for back-port to 1.4.x and probably even 1.3.x.

Thanks for the patch!

-- 
David Wayne Summers        "Linux: Because reboots are for hardware upgrades!"
david@summersoft.fay.ar.us PGP Key: http://summersoft.fay.ar.us/~david/pgp.txt
PGP Key fingerprint =  0B44 B118 85CC F4EC 7021  1ED4 1516 5B78 E320 2001

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Re: Agggh! 64-bit bug still present in 1.3.2 [PATCH]

Posted by Toby Johnson <to...@etjohnson.us>.
Toby Johnson wrote:
> David Summers wrote:
>>
>> OK, that patch fails when I applied it to a 32-bit system so we need
>> an %ifarch statement there.  If you could do that and try it out and 
>> if it works send that patch or tonight I can try to do that and send 
>> it to you and then you could try it out and let me know.  Either way 
>> is fine.  If I don't hear from you then I'll try to generate that 
>> tonight and send it out.
> Hi David,
>
> I'll work on getting that added; can you specify which part of the 
> patch causes the failure? (Or what the failure message is...)
>
FYI, I just tried building on CentOS-4 32-bit, with all tests enabled, 
and it built cleanly with all tests passed. What are the specifics of 
your build system? I can't imagine which of the three lines I changed 
could be causing the failure.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Re: Agggh! 64-bit bug still present in 1.3.2 [PATCH]

Posted by Toby Johnson <to...@etjohnson.us>.
David Summers wrote:
>
> OK, that patch fails when I applied it to a 32-bit system so we need
> an %ifarch statement there.  If you could do that and try it out and 
> if it works send that patch or tonight I can try to do that and send 
> it to you and then you could try it out and let me know.  Either way 
> is fine.  If I don't hear from you then I'll try to generate that 
> tonight and send it out.
Hi David,

I'll work on getting that added; can you specify which part of the patch 
causes the failure? (Or what the failure message is...)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Re: Agggh! 64-bit bug still present in 1.3.2 [PATCH]

Posted by David Summers <da...@summersoft.fay.ar.us>.
OK, that patch fails when I applied it to a 32-bit system so we need
an %ifarch statement there.  If you could do that and try it out and if it 
works send that patch or tonight I can try to do that and send it to you 
and then you could try it out and let me know.  Either way is fine.  If I 
don't hear from you then I'll try to generate that tonight and send it 
out.

    Thanks.
    - David

On Wed, 21 Jun 2006, Toby Johnson wrote:

> Date: Wed, 21 Jun 2006 00:54:48 -0400
> From: Toby Johnson <to...@etjohnson.us>
> To: David Summers <da...@summersoft.fay.ar.us>
> Cc: Nico Kadel-Garcia <nk...@comcast.net>, dev <de...@subversion.tigris.org>
> Subject: Re: Agggh! 64-bit bug still present in 1.3.2 [PATCH]
> 
> David Summers wrote:
>> 
>> On Mon, 5 Jun 2006, Toby Johnson wrote:
>> 
>>> Nico Kadel-Garcia wrote:
>>>> My latest patch is at:
>>>>
>>>>    http://subversion.tigris.org/nonav/issues/showattachment.cgi/558/x86_64.patch 
>>> 
>>> 
>>> Nico, as long as we're replacing hardcoded paths with built-in rpmbuild 
>>> macros, shouldn't the following substitutions also be made?
>>> 
>>> /usr/bin => %{_bindir}
>>> /usr/include => %{_includedir}
>>> /usr/share/man => %{_mandir}
>>> /usr/share => %{_datadir}
>>> 
>> 
>> If someone could try the latest trunk and see if my /usr/bin -> %{_bindir}
>> and /usr/lib -> %{_libdir} has helped 64-bit users at all and let me know, 
>> it would be appreciated.
>> 
>> I still don't have a 64-bit system but I will soon order one (yay, more 
>> toys) so hopefully soon I'll be able to verify this stuff.
>> 
>> Until then, I either need feedback from someone else or if someone could 
>> offer a login on a 64-bit system for a while that would be appreciated.
>> 
>> If we can get a clean 64-bit RPM build on trunk then we can back-port to 
>> 1.4.x and/or 1.3.x.
>> 
>
> Hello David, I finished running without checks enabled on 64-bit CentOS-4 and 
> hit a couple snags, which the attached patch corrects (just a couple more 
> missed /usr/lib64 locations). I'm assuming the patch can/should be applied 
> for the other distros as well but I currently have no means of testing those.
>
> The Makefile for building the RPMs still doesn't work, due to the hardcoded 
> 32-bit paths in there, but I'm not really worried about that... it makes it 
> up to and including creation of the RPMs anyway.
>
> I'll run again with full tests and let you know if I find anything else.
>
> toby
>

-- 
David Wayne Summers        "Linux: Because reboots are for hardware upgrades!"
david@summersoft.fay.ar.us PGP Key: http://summersoft.fay.ar.us/~david/pgp.txt
PGP Key fingerprint =  0B44 B118 85CC F4EC 7021  1ED4 1516 5B78 E320 2001

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Re: Agggh! 64-bit bug still present in 1.3.2 [PATCH]

Posted by Toby Johnson <to...@etjohnson.us>.
Nico Kadel-Garcia wrote:
> Toby Johnson wrote:
>
>>> Hello David, I finished running without checks enabled on 64-bit
>>> CentOS-4 and hit a couple snags, which the attached patch corrects
>>> (just a couple more missed /usr/lib64 locations). I'm assuming the
>>> patch can/should be applied for the other distros as well but I
>>> currently have no means of testing those.
>>>
>>> The Makefile for building the RPMs still doesn't work, due to the
>>> hardcoded 32-bit paths in there, but I'm not really worried about
>>> that... it makes it up to and including creation of the RPMs anyway.
>>>
>>> I'll run again with full tests and let you know if I find anything
>>> else.
>>>
>>> toby
>
> Hmm. David? It looks like you integrated in my earlier patch, not the 
> later one I published in the bug system at 
> http://subversion.tigris.org/nonav/issues/showattachment.cgi/558/x86_64.patch. 


I'm not sure what was different between your latest patch and what David 
changed, but I confirmed that with the patch attached to my previous 
email, the build completes correctly with all tests enabled.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Re: Agggh! 64-bit bug still present in 1.3.2 [PATCH]

Posted by Nico Kadel-Garcia <nk...@comcast.net>.
Toby Johnson wrote:

>> Hello David, I finished running without checks enabled on 64-bit
>> CentOS-4 and hit a couple snags, which the attached patch corrects
>> (just a couple more missed /usr/lib64 locations). I'm assuming the
>> patch can/should be applied for the other distros as well but I
>> currently have no means of testing those.
>>
>> The Makefile for building the RPMs still doesn't work, due to the
>> hardcoded 32-bit paths in there, but I'm not really worried about
>> that... it makes it up to and including creation of the RPMs anyway.
>>
>> I'll run again with full tests and let you know if I find anything
>> else.
>>
>> toby

Hmm. David? It looks like you integrated in my earlier patch, not the later 
one I published in the bug system at 
http://subversion.tigris.org/nonav/issues/showattachment.cgi/558/x86_64.patch. 

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org