You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by "magicgoody (via GitHub)" <gi...@apache.org> on 2023/09/11 10:28:33 UTC
[GitHub] [beam] magicgoody opened a new pull request, #28391: Github Workflow Replacement for Jenkins Job, beam_PostCommit_Website_Publish
magicgoody opened a new pull request, #28391:
URL: https://github.com/apache/beam/pull/28391
PR migrates Jenkins Jobs to Github Actions Workflow ".github/workflows/beam_PostCommit_Website_Publish.yml":
https://ci-beam.apache.org/view/PostCommit/job/beam_PostCommit_Website_Publish/
The code has been tested on Self-hosted GKE runners ubuntu 20.04.
https://github.com/magicgoody/beam/actions/runs/6143300368
------------------------
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment `fixes #<ISSUE NUMBER>` instead.
- [ ] Update `CHANGES.md` with noteworthy changes.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://github.com/apache/beam/blob/master/CONTRIBUTING.md#make-the-reviewers-job-easier).
To check the build health, please visit [https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
GitHub Actions Tests Status (on master branch)
------------------------------------------------------------------------------------------------
[](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Go+tests%22+branch%3Amaster+event%3Aschedule)
See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI or the [workflows README](https://github.com/apache/beam/blob/master/.github/workflows/README.md) to see a list of phrases to trigger workflows.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] damccorm merged pull request #28391: Github Workflow Replacement for Jenkins Job, beam_PostCommit_Website_Publish
Posted by "damccorm (via GitHub)" <gi...@apache.org>.
damccorm merged PR #28391:
URL: https://github.com/apache/beam/pull/28391
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] damccorm commented on a diff in pull request #28391: Github Workflow Replacement for Jenkins Job, beam_PostCommit_Website_Publish
Posted by "damccorm (via GitHub)" <gi...@apache.org>.
damccorm commented on code in PR #28391:
URL: https://github.com/apache/beam/pull/28391#discussion_r1324405302
##########
.github/workflows/beam_PostCommit_Website_Publish.yml:
##########
@@ -0,0 +1,63 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+name: PostCommit Website Publish
+
+on:
+ schedule:
+ - cron: '0 */6 * * *'
+ workflow_dispatch:
+
+#Setting explicit permissions for the action to avoid the default permissions which are `write-all` in case of pull_request_target event
+permissions:
+ actions: write
+ pull-requests: read
+ checks: read
+ contents: write
+ deployments: read
+ id-token: none
+ issues: read
+ discussions: read
+ packages: read
+ pages: read
+ repository-projects: read
+ security-events: read
+ statuses: read
+
+# This allows a subsequently queued workflow run to interrupt previous runs
+concurrency:
+ group: '${{ github.workflow }} @ ${{ github.event.issue.number || github.event.pull_request.head.label || github.sha || github.head_ref || github.ref }}-${{ github.event.schedule || github.event.comment.body || github.event.sender.login}}'
+ cancel-in-progress: true
+
+env:
+ GRADLE_ENTERPRISE_ACCESS_KEY: ${{ secrets.GE_ACCESS_TOKEN }}
+ GRADLE_ENTERPRISE_CACHE_USERNAME: ${{ secrets.GE_CACHE_USERNAME }}
+ GRADLE_ENTERPRISE_CACHE_PASSWORD: ${{ secrets.GE_CACHE_PASSWORD }}
+
+jobs:
+ beam_PostCommit_Website_Publish:
+ if: |
+ github.event_name == 'workflow_dispatch' ||
+ github.event_name == 'schedule'
+ runs-on: [self-hosted, ubuntu-20.04, main]
+ timeout-minutes: 30
+ name: beam_PostCommit_Website_Publish
+ steps:
+ - uses: actions/checkout@v3
+ - name: run PostCommit Website Publish script
+ uses: ./.github/actions/gradle-command-self-hosted-action
+ with:
+ gradle-command: :website:clean :website:publishWebsite
+ arguments: -PgitPublishRemote="https://github.com/apache/beam.git"
Review Comment:
Thanks, removing the groovy file is fine!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] damccorm commented on a diff in pull request #28391: Github Workflow Replacement for Jenkins Job, beam_PostCommit_Website_Publish
Posted by "damccorm (via GitHub)" <gi...@apache.org>.
damccorm commented on code in PR #28391:
URL: https://github.com/apache/beam/pull/28391#discussion_r1323147733
##########
.github/workflows/beam_PostCommit_Website_Publish.yml:
##########
@@ -0,0 +1,63 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+name: PostCommit Website Publish
+
+on:
+ schedule:
+ - cron: '0 */6 * * *'
+ workflow_dispatch:
+
+#Setting explicit permissions for the action to avoid the default permissions which are `write-all` in case of pull_request_target event
+permissions:
+ actions: write
+ pull-requests: read
+ checks: read
+ contents: write
+ deployments: read
+ id-token: none
+ issues: read
+ discussions: read
+ packages: read
+ pages: read
+ repository-projects: read
+ security-events: read
+ statuses: read
+
+# This allows a subsequently queued workflow run to interrupt previous runs
+concurrency:
+ group: '${{ github.workflow }} @ ${{ github.event.issue.number || github.event.pull_request.head.label || github.sha || github.head_ref || github.ref }}-${{ github.event.schedule || github.event.comment.body || github.event.sender.login}}'
+ cancel-in-progress: true
+
+env:
+ GRADLE_ENTERPRISE_ACCESS_KEY: ${{ secrets.GE_ACCESS_TOKEN }}
+ GRADLE_ENTERPRISE_CACHE_USERNAME: ${{ secrets.GE_CACHE_USERNAME }}
+ GRADLE_ENTERPRISE_CACHE_PASSWORD: ${{ secrets.GE_CACHE_PASSWORD }}
+
+jobs:
+ beam_PostCommit_Website_Publish:
+ if: |
+ github.event_name == 'workflow_dispatch' ||
+ github.event_name == 'schedule'
+ runs-on: [self-hosted, ubuntu-20.04, main]
+ timeout-minutes: 30
+ name: beam_PostCommit_Website_Publish
+ steps:
+ - uses: actions/checkout@v3
+ - name: run PostCommit Website Publish script
+ uses: ./.github/actions/gradle-command-self-hosted-action
+ with:
+ gradle-command: :website:clean :website:publishWebsite
+ arguments: -PgitPublishRemote="https://github.com/apache/beam.git"
Review Comment:
This will eventually commit to git after everything has run and will create a race condition where either this or the Jenkins job will commit first and win. Could we just disable the Jenkins job as part of this PR?
We should then closely monitor the job and revert if it is not working correctly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] github-actions[bot] commented on pull request #28391: Github Workflow Replacement for Jenkins Job, beam_PostCommit_Website_Publish
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #28391:
URL: https://github.com/apache/beam/pull/28391#issuecomment-1715472129
Assigning reviewers. If you would like to opt out of this review, comment `assign to next reviewer`:
R: @damccorm for label build.
Available commands:
- `stop reviewer notifications` - opt out of the automated review tooling
- `remind me after tests pass` - tag the comment author after tests pass
- `waiting on author` - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)
The PR bot will only process comments in the main thread (not review comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] magicgoody commented on a diff in pull request #28391: Github Workflow Replacement for Jenkins Job, beam_PostCommit_Website_Publish
Posted by "magicgoody (via GitHub)" <gi...@apache.org>.
magicgoody commented on code in PR #28391:
URL: https://github.com/apache/beam/pull/28391#discussion_r1324174827
##########
.github/workflows/beam_PostCommit_Website_Publish.yml:
##########
@@ -0,0 +1,63 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+name: PostCommit Website Publish
+
+on:
+ schedule:
+ - cron: '0 */6 * * *'
+ workflow_dispatch:
+
+#Setting explicit permissions for the action to avoid the default permissions which are `write-all` in case of pull_request_target event
+permissions:
+ actions: write
+ pull-requests: read
+ checks: read
+ contents: write
+ deployments: read
+ id-token: none
+ issues: read
+ discussions: read
+ packages: read
+ pages: read
+ repository-projects: read
+ security-events: read
+ statuses: read
+
+# This allows a subsequently queued workflow run to interrupt previous runs
+concurrency:
+ group: '${{ github.workflow }} @ ${{ github.event.issue.number || github.event.pull_request.head.label || github.sha || github.head_ref || github.ref }}-${{ github.event.schedule || github.event.comment.body || github.event.sender.login}}'
+ cancel-in-progress: true
+
+env:
+ GRADLE_ENTERPRISE_ACCESS_KEY: ${{ secrets.GE_ACCESS_TOKEN }}
+ GRADLE_ENTERPRISE_CACHE_USERNAME: ${{ secrets.GE_CACHE_USERNAME }}
+ GRADLE_ENTERPRISE_CACHE_PASSWORD: ${{ secrets.GE_CACHE_PASSWORD }}
+
+jobs:
+ beam_PostCommit_Website_Publish:
+ if: |
+ github.event_name == 'workflow_dispatch' ||
+ github.event_name == 'schedule'
+ runs-on: [self-hosted, ubuntu-20.04, main]
+ timeout-minutes: 30
+ name: beam_PostCommit_Website_Publish
+ steps:
+ - uses: actions/checkout@v3
+ - name: run PostCommit Website Publish script
+ uses: ./.github/actions/gradle-command-self-hosted-action
+ with:
+ gradle-command: :website:clean :website:publishWebsite
+ arguments: -PgitPublishRemote="https://github.com/apache/beam.git"
Review Comment:
Hello @damccorm
We can remove ".test-infra\jenkins\job_PostCommit_Website_Publish.groovy", so the job won't run. Or it can also be disabled in the Jenkins admin page, however we don't have access to it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org