You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/08/26 09:37:10 UTC

[GitHub] [superset] nguyenluongky opened a new issue #16462: The Actual time range not show correct with SIP-15 on Superset version 1.2

nguyenluongky opened a new issue #16462:
URL: https://github.com/apache/superset/issues/16462


   Currently, we use Native filter on Superset version 1.2, but looks like The actual time range does not show correctly with SIP-15 (in the SIP-15 the time range must is [inclusive, exclusive) ). So that mean the actual time range and the tool tip must show label as: from_date <= col < to_date.
   
   
   
   ### Expected results
   ![image](https://user-images.githubusercontent.com/37523968/130939207-7ff847aa-8503-46b7-abd0-af2b3deaea07.png)
   
   ### Actual results
   ![image](https://user-images.githubusercontent.com/37523968/130939276-1b2a5f91-d5ba-4c4f-9007-3cba91ff30f8.png)
   
   ### Environment
   
   (please complete the following information):
   
   - superset version: `1.2`
   - python version: `3.7
   
   ### Checklist
   
   Make sure to follow these steps before submitting your issue - thank you!
   
   - [ ] I have rated this issue on slack community and they advice me to create a ticket.
   - [ ] I tried with the config SIP_15_DEFAULT_TIME_RANGE_ENDPOINTS = ["inclusive", "inclusive"] but doesn't help.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] junlincc commented on issue #16462: [time_picker]start date display is not inclusive

Posted by GitBox <gi...@apache.org>.
junlincc commented on issue #16462:
URL: https://github.com/apache/superset/issues/16462#issuecomment-906535501


   thanks for reporting, if you click view query from dashboard with a time filter, you will notice the query is actually accurate even though the display is wrong. we will push a fix for the display soon. 
   <img width="871" alt="Screen Shot 2021-08-26 at 10 53 54 AM" src="https://user-images.githubusercontent.com/67837651/130995497-d112da61-4654-4917-b77c-35c16db0221e.png">
   <img width="503" alt="Screen Shot 2021-08-26 at 10 54 01 AM" src="https://user-images.githubusercontent.com/67837651/130995503-96e195e7-1c62-47eb-b778-e60fbad29bb8.png">
    
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] nguyenluongky commented on issue #16462: [time_picker]start date display is not inclusive

Posted by GitBox <gi...@apache.org>.
nguyenluongky commented on issue #16462:
URL: https://github.com/apache/superset/issues/16462#issuecomment-906905603


   Thanks @junlincc ,
   The query is correct, It is just a problem on UI only so it makes confuse for end-user then :).
   And I also noted that this problem occurred because of Native filter doesn't submit the `time_range_endpoints` so by default it always use `<` operator to display. Correct me if I wrong.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] yongchand commented on issue #16462: [time_picker]start date display is not inclusive

Posted by GitBox <gi...@apache.org>.
yongchand commented on issue #16462:
URL: https://github.com/apache/superset/issues/16462#issuecomment-943110322


   Any updates for this issue? @junlincc 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org