You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@zeppelin.apache.org by "kevinjmh (via GitHub)" <gi...@apache.org> on 2024/04/25 08:59:13 UTC

Re: [PR] [ZEPPELIN-5421] Update surefire version [zeppelin]

kevinjmh commented on code in PR #4146:
URL: https://github.com/apache/zeppelin/pull/4146#discussion_r1579130139


##########
bin/common.sh:
##########
@@ -171,10 +171,6 @@ else
 fi
 export ZEPPELIN_RUNNER
 
-if [[ -z "$ZEPPELIN_IDENT_STRING" ]]; then
-  export ZEPPELIN_IDENT_STRING="${USER}"
-fi

Review Comment:
   log filename seems weird after this removal when I just upgrade from zeppelin 10.0.1 to 11.0.0
   
   ```
   zeppelin--SERVER.log.2024-04-24
   zeppelin--SERVER.out
   zeppelin-interpreter-jdbc-shared_process--SERVER.log
   ```
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@zeppelin.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org