[GitHub] [arrow-rs] alamb commented on a diff in pull request #3678: Minor: Add some examples to Date*Array and Time*Array

["alamb (via GitHub)" <gi...@apache.org>]

alamb commented on code in PR #3678:
URL: https://github.com/apache/arrow-rs/pull/3678#discussion_r1100713907


##########
arrow-array/src/array/primitive_array.rs:
##########
@@ -168,22 +168,42 @@ pub type TimestampNanosecondArray = PrimitiveArray<TimestampNanosecondType>;
 
 // TODO: give examples for the below types
 
-/// A primitive array where each element is of 32-bit date type.
+/// A primitive array where each element is of 32-bit value
+/// representing the elapsed time since UNIX epoch in days."
+///
+/// This type is similar to the [`chrono::NaiveDate`] type and can hold
+/// values such as `2018-11-13`
 pub type Date32Array = PrimitiveArray<Date32Type>;
-/// A primitive array where each element is of 64-bit date type.
+/// A primitive array where each element is a 64-bit value
+/// representing the elapsed time since the UNIX epoch in milliseconds.
+///
+/// This type is similar to the [`chrono::DateTime`] type and can hold

Review Comment:
   in a685bf8d3



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org