You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by rhusar <gi...@git.apache.org> on 2016/07/28 17:31:40 UTC
[GitHub] tomcat pull request #33: Clear up confusion about mbeans-descriptors.xml in ...
GitHub user rhusar opened a pull request:
https://github.com/apache/tomcat/pull/33
Clear up confusion about mbeans-descriptors.xml in docs; fix a type i\u2026
\u2026n core descriptor
Lets make sure its everywhere called "mbeans-descriptors" otherwise one missing "s" can cost developers quite a while debugging what is wrong.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/rhusar/tomcat mbeans-descriptors-docs-fix
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/tomcat/pull/33.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #33
----
commit 2c4ac40f44d07015d51f3e1306bd447cf43e2ff1
Author: Radoslav Husar <ra...@gmail.com>
Date: 2016-07-28T17:21:43Z
Clear up confusion about mbeans-descriptors.xml in docs; fix a type in core descriptor
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[GitHub] tomcat issue #33: Clear up confusion about mbeans-descriptors.xml in docs; f...
Posted by rhusar <gi...@git.apache.org>.
Github user rhusar commented on the issue:
https://github.com/apache/tomcat/pull/33
\U0001f44d
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[GitHub] tomcat issue #33: Clear up confusion about mbeans-descriptors.xml in docs; f...
Posted by rhusar <gi...@git.apache.org>.
Github user rhusar commented on the issue:
https://github.com/apache/tomcat/pull/33
My thinking is that first, we need to stop perpetuating the wrong name "mbeans-descriptor" which is the name of the page, and more importantly, the page gives such a bad advice that it deserves a rename since nobody could have been using it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[GitHub] tomcat issue #33: Clear up confusion about mbeans-descriptors.xml in docs; f...
Posted by violetagg <gi...@git.apache.org>.
Github user violetagg commented on the issue:
https://github.com/apache/tomcat/pull/33
Hi,
Your patch was applied with r1755717.
Regards,
Violeta
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[GitHub] tomcat issue #33: Clear up confusion about mbeans-descriptors.xml in docs; f...
Posted by markt-asf <gi...@git.apache.org>.
Github user markt-asf commented on the issue:
https://github.com/apache/tomcat/pull/33
Rename the page. If someone complains, we can look at adding a redirect although we'll need to handle both Tomcat (for releases) and httpd (for the website). I'd prefer to have a single solution for both but I don;t see one at this point.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[GitHub] tomcat pull request #33: Clear up confusion about mbeans-descriptors.xml in ...
Posted by markt-asf <gi...@git.apache.org>.
Github user markt-asf closed the pull request at:
https://github.com/apache/tomcat/pull/33
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[GitHub] tomcat issue #33: Clear up confusion about mbeans-descriptors.xml in docs; f...
Posted by violetagg <gi...@git.apache.org>.
Github user violetagg commented on the issue:
https://github.com/apache/tomcat/pull/33
Hi,
I have one comment about renaming the page.
If there are bookmarks to that page with this change we will break these bookmarks.
Otherwise the change is OK.
Wdyt?
Regards,
Violeta
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[GitHub] tomcat issue #33: Clear up confusion about mbeans-descriptors.xml in docs; f...
Posted by violetagg <gi...@git.apache.org>.
Github user violetagg commented on the issue:
https://github.com/apache/tomcat/pull/33
Hello,
Typos are fixed with r1755675.
Regards,
Violeta
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org