You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "Martin Dietze (JIRA)" <ji...@apache.org> on 2009/12/01 19:28:20 UTC
[jira] Created: (WICKET-2595) Ajax Upload fails in nested form
(ModalWindow)
Ajax Upload fails in nested form (ModalWindow)
----------------------------------------------
Key: WICKET-2595
URL: https://issues.apache.org/jira/browse/WICKET-2595
Project: Wicket
Issue Type: Bug
Components: wicket
Affects Versions: 1.4.3
Environment: Linux i686, glibc 2.10, jdk 1.6.07
Reporter: Martin Dietze
When using a file upload in a nested form (e.g. as required when using modal windows), the file upload will always return null. This bug seems related to WICKET-2433 which was supposed to be fixed in wicket 1.4.2, but in wicket 1.4.3 this effect was observed by several people (see mailing list).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-2595) Ajax multipart fails for inner
forms added via ajax
Posted by "Doug Leeper (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-2595?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12787242#action_12787242 ]
Doug Leeper commented on WICKET-2595:
-------------------------------------
works perfect for me...Thanks!
> Ajax multipart fails for inner forms added via ajax
> ---------------------------------------------------
>
> Key: WICKET-2595
> URL: https://issues.apache.org/jira/browse/WICKET-2595
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.4.3
> Environment: Linux i686, glibc 2.10, jdk 1.6.07
> Reporter: Martin Dietze
> Assignee: Igor Vaynberg
> Fix For: 1.4.4, 1.5-M1
>
> Attachments: fileupload-example.zip, Form.java.diff, quickstart.jar, wicket-ajax.js.diff
>
>
> When using a file upload in a nested form (e.g. as required when using modal windows), the file upload will always return null. This bug seems related to WICKET-2433 which was supposed to be fixed in wicket 1.4.2, but in wicket 1.4.3 this effect was observed by several people (see mailing list).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WICKET-2595) Ajax multipart fails for inner forms
added via ajax
Posted by "Doug Leeper (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-2595?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Doug Leeper updated WICKET-2595:
--------------------------------
Attachment: wicket-ajax.js.diff
Form.java.diff
My apologies. You had indicated you wanted a quick start so I did. Here are the changes in svn diff format. BTW...I modified wicket-ajax.js to keep original enctype and to reset to the original after the form has been submitted. So these diff are the latest.
> Ajax multipart fails for inner forms added via ajax
> ---------------------------------------------------
>
> Key: WICKET-2595
> URL: https://issues.apache.org/jira/browse/WICKET-2595
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.4.3
> Environment: Linux i686, glibc 2.10, jdk 1.6.07
> Reporter: Martin Dietze
> Assignee: Igor Vaynberg
> Fix For: 1.4.4, 1.5-M1
>
> Attachments: fileupload-example.zip, Form.java.diff, quickstart.jar, wicket-ajax.js.diff
>
>
> When using a file upload in a nested form (e.g. as required when using modal windows), the file upload will always return null. This bug seems related to WICKET-2433 which was supposed to be fixed in wicket 1.4.2, but in wicket 1.4.3 this effect was observed by several people (see mailing list).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-2595) Ajax Upload fails in nested form
(ModalWindow)
Posted by "Igor Vaynberg (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-2595?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12785770#action_12785770 ]
Igor Vaynberg commented on WICKET-2595:
---------------------------------------
please try with wicket-1.4.x snapshot built from svn, this should already be fixed.
> Ajax Upload fails in nested form (ModalWindow)
> ----------------------------------------------
>
> Key: WICKET-2595
> URL: https://issues.apache.org/jira/browse/WICKET-2595
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.4.3
> Environment: Linux i686, glibc 2.10, jdk 1.6.07
> Reporter: Martin Dietze
> Attachments: fileupload-example.zip
>
>
> When using a file upload in a nested form (e.g. as required when using modal windows), the file upload will always return null. This bug seems related to WICKET-2433 which was supposed to be fixed in wicket 1.4.2, but in wicket 1.4.3 this effect was observed by several people (see mailing list).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-2595) Ajax multipart fails for inner
forms added via ajax
Posted by "Igor Vaynberg (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-2595?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12786822#action_12786822 ]
Igor Vaynberg commented on WICKET-2595:
---------------------------------------
in the future please attach your proposed fixes as patches. it is hard to spot a few line changes here and there in a huge file, so i did not even bother looking....
> Ajax multipart fails for inner forms added via ajax
> ---------------------------------------------------
>
> Key: WICKET-2595
> URL: https://issues.apache.org/jira/browse/WICKET-2595
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.4.3
> Environment: Linux i686, glibc 2.10, jdk 1.6.07
> Reporter: Martin Dietze
> Assignee: Igor Vaynberg
> Fix For: 1.4.4, 1.5-M1
>
> Attachments: fileupload-example.zip, quickstart.jar
>
>
> When using a file upload in a nested form (e.g. as required when using modal windows), the file upload will always return null. This bug seems related to WICKET-2433 which was supposed to be fixed in wicket 1.4.2, but in wicket 1.4.3 this effect was observed by several people (see mailing list).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-2595) Ajax multipart fails for inner
forms added via ajax
Posted by "Igor Vaynberg (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-2595?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12786982#action_12786982 ]
Igor Vaynberg commented on WICKET-2595:
---------------------------------------
a quickstart to demonstrate the bug, patches to demonstrate a solution :)
> Ajax multipart fails for inner forms added via ajax
> ---------------------------------------------------
>
> Key: WICKET-2595
> URL: https://issues.apache.org/jira/browse/WICKET-2595
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.4.3
> Environment: Linux i686, glibc 2.10, jdk 1.6.07
> Reporter: Martin Dietze
> Assignee: Igor Vaynberg
> Fix For: 1.4.4, 1.5-M1
>
> Attachments: fileupload-example.zip, Form.java.diff, quickstart.jar, wicket-ajax.js.diff
>
>
> When using a file upload in a nested form (e.g. as required when using modal windows), the file upload will always return null. This bug seems related to WICKET-2433 which was supposed to be fixed in wicket 1.4.2, but in wicket 1.4.3 this effect was observed by several people (see mailing list).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WICKET-2595) Ajax multipart fails for inner forms
added via ajax
Posted by "Igor Vaynberg (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-2595?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Igor Vaynberg updated WICKET-2595:
----------------------------------
Summary: Ajax multipart fails for inner forms added via ajax (was: Ajax Upload fails in nested form (ModalWindow))
> Ajax multipart fails for inner forms added via ajax
> ---------------------------------------------------
>
> Key: WICKET-2595
> URL: https://issues.apache.org/jira/browse/WICKET-2595
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.4.3
> Environment: Linux i686, glibc 2.10, jdk 1.6.07
> Reporter: Martin Dietze
> Fix For: 1.4.4, 1.5-M1
>
> Attachments: fileupload-example.zip, quickstart.jar
>
>
> When using a file upload in a nested form (e.g. as required when using modal windows), the file upload will always return null. This bug seems related to WICKET-2433 which was supposed to be fixed in wicket 1.4.2, but in wicket 1.4.3 this effect was observed by several people (see mailing list).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-2595) Ajax multipart fails for inner
forms added via ajax
Posted by "Igor Vaynberg (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-2595?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12786984#action_12786984 ]
Igor Vaynberg commented on WICKET-2595:
---------------------------------------
have you tried with the latest snapshot? does it work for you now?
> Ajax multipart fails for inner forms added via ajax
> ---------------------------------------------------
>
> Key: WICKET-2595
> URL: https://issues.apache.org/jira/browse/WICKET-2595
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.4.3
> Environment: Linux i686, glibc 2.10, jdk 1.6.07
> Reporter: Martin Dietze
> Assignee: Igor Vaynberg
> Fix For: 1.4.4, 1.5-M1
>
> Attachments: fileupload-example.zip, Form.java.diff, quickstart.jar, wicket-ajax.js.diff
>
>
> When using a file upload in a nested form (e.g. as required when using modal windows), the file upload will always return null. This bug seems related to WICKET-2433 which was supposed to be fixed in wicket 1.4.2, but in wicket 1.4.3 this effect was observed by several people (see mailing list).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (WICKET-2595) Ajax multipart fails for inner forms
added via ajax
Posted by "Igor Vaynberg (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-2595?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Igor Vaynberg resolved WICKET-2595.
-----------------------------------
Resolution: Fixed
Fix Version/s: 1.5-M1
1.4.4
Assignee: Igor Vaynberg
> Ajax multipart fails for inner forms added via ajax
> ---------------------------------------------------
>
> Key: WICKET-2595
> URL: https://issues.apache.org/jira/browse/WICKET-2595
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.4.3
> Environment: Linux i686, glibc 2.10, jdk 1.6.07
> Reporter: Martin Dietze
> Assignee: Igor Vaynberg
> Fix For: 1.4.4, 1.5-M1
>
> Attachments: fileupload-example.zip, quickstart.jar
>
>
> When using a file upload in a nested form (e.g. as required when using modal windows), the file upload will always return null. This bug seems related to WICKET-2433 which was supposed to be fixed in wicket 1.4.2, but in wicket 1.4.3 this effect was observed by several people (see mailing list).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WICKET-2595) Ajax Upload fails in nested form
(ModalWindow)
Posted by "Doug Leeper (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-2595?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Doug Leeper updated WICKET-2595:
--------------------------------
Attachment: quickstart.jar
I have attached a quick start that reproduces the error in question.
Note: i have also include my suggested fix to Form and wicket-ajax.js. The fix does allow the form to be submitted in inline frame. However, my button.onSubmit is not being called...not sure why.
Note: without the fix, I get a ServletRequest is not a MultipartServletRequest Exception. To see...move Form.java out of the project and rerun.
> Ajax Upload fails in nested form (ModalWindow)
> ----------------------------------------------
>
> Key: WICKET-2595
> URL: https://issues.apache.org/jira/browse/WICKET-2595
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.4.3
> Environment: Linux i686, glibc 2.10, jdk 1.6.07
> Reporter: Martin Dietze
> Attachments: fileupload-example.zip, quickstart.jar
>
>
> When using a file upload in a nested form (e.g. as required when using modal windows), the file upload will always return null. This bug seems related to WICKET-2433 which was supposed to be fixed in wicket 1.4.2, but in wicket 1.4.3 this effect was observed by several people (see mailing list).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WICKET-2595) Ajax Upload fails in nested form
(ModalWindow)
Posted by "Martin Dietze (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-2595?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Martin Dietze updated WICKET-2595:
----------------------------------
Attachment: fileupload-example.zip
The attached file contains a modified version of the ajax upload page from wicket examples. When instanciating the modal window it is added to a wrapper form which causes the upload always to fail. If modifying the code by removing the wrapper form and adding the modal window to the page instead, the upload works.
> Ajax Upload fails in nested form (ModalWindow)
> ----------------------------------------------
>
> Key: WICKET-2595
> URL: https://issues.apache.org/jira/browse/WICKET-2595
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.4.3
> Environment: Linux i686, glibc 2.10, jdk 1.6.07
> Reporter: Martin Dietze
> Attachments: fileupload-example.zip
>
>
> When using a file upload in a nested form (e.g. as required when using modal windows), the file upload will always return null. This bug seems related to WICKET-2433 which was supposed to be fixed in wicket 1.4.2, but in wicket 1.4.3 this effect was observed by several people (see mailing list).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.