You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by Bill Farner <wf...@apache.org> on 2015/08/28 00:50:17 UTC
Review Request 37860: Rpm: fix install dep on daemonize,
be permissive with newer mesos versions.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37860/
-----------------------------------------------------------
Review request for Aurora and Kevin Sweeney.
Repository: aurora-packaging
Description
-------
Rpm: fix install dep on daemonize, be permissive with newer mesos versions.
Diffs
-----
specs/rpm/aurora.spec 3e7b8bef2272d935f3efb3e3ea6e4ac510026b7d
Diff: https://reviews.apache.org/r/37860/diff/
Testing
-------
Successfully ran what jenkins runs:
```
./build-artifact.sh builder/rpm/centos-7 ~/snapshot.tar.gz 0.10.0snapshot.2015.08.27
```
Thanks,
Bill Farner
Re: Review Request 37860: Rpm: fix install dep on daemonize,
be permissive with newer mesos versions.
Posted by Bill Farner <wf...@apache.org>.
> On Aug. 27, 2015, 3:55 p.m., Kevin Sweeney wrote:
> > specs/rpm/aurora.spec, line 100
> > <https://reviews.apache.org/r/37860/diff/1/?file=1056661#file1056661line100>
> >
> > Can you explain the rationale behind this change - unpinned mesos runs the risk of not working with the executor it was compiled against. Much as we might wish that this will work, we don't know that it will and it's much easier to debug an error from yum than a runtime linker issue. If a user is convinced that we're wrong here they can always override with `--nodeps`.
Sure, i'll abandon. Perhaps the right approach will be for us to do point releases to pick up new mesos versions.
- Bill
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37860/#review96782
-----------------------------------------------------------
On Aug. 27, 2015, 3:50 p.m., Bill Farner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37860/
> -----------------------------------------------------------
>
> (Updated Aug. 27, 2015, 3:50 p.m.)
>
>
> Review request for Aurora and Kevin Sweeney.
>
>
> Repository: aurora-packaging
>
>
> Description
> -------
>
> Rpm: fix install dep on daemonize, be permissive with newer mesos versions.
>
>
> Diffs
> -----
>
> specs/rpm/aurora.spec 3e7b8bef2272d935f3efb3e3ea6e4ac510026b7d
>
> Diff: https://reviews.apache.org/r/37860/diff/
>
>
> Testing
> -------
>
> Successfully ran what jenkins runs:
> ```
> ./build-artifact.sh builder/rpm/centos-7 ~/snapshot.tar.gz 0.10.0snapshot.2015.08.27
> ```
>
>
> Thanks,
>
> Bill Farner
>
>
Re: Review Request 37860: Rpm: fix install dep on daemonize,
be permissive with newer mesos versions.
Posted by Kevin Sweeney <ke...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37860/#review96782
-----------------------------------------------------------
specs/rpm/aurora.spec (line 100)
<https://reviews.apache.org/r/37860/#comment152429>
Can you explain the rationale behind this change - unpinned mesos runs the risk of not working with the executor it was compiled against. Much as we might wish that this will work, we don't know that it will and it's much easier to debug an error from yum than a runtime linker issue. If a user is convinced that we're wrong here they can always override with `--nodeps`.
- Kevin Sweeney
On Aug. 27, 2015, 3:50 p.m., Bill Farner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37860/
> -----------------------------------------------------------
>
> (Updated Aug. 27, 2015, 3:50 p.m.)
>
>
> Review request for Aurora and Kevin Sweeney.
>
>
> Repository: aurora-packaging
>
>
> Description
> -------
>
> Rpm: fix install dep on daemonize, be permissive with newer mesos versions.
>
>
> Diffs
> -----
>
> specs/rpm/aurora.spec 3e7b8bef2272d935f3efb3e3ea6e4ac510026b7d
>
> Diff: https://reviews.apache.org/r/37860/diff/
>
>
> Testing
> -------
>
> Successfully ran what jenkins runs:
> ```
> ./build-artifact.sh builder/rpm/centos-7 ~/snapshot.tar.gz 0.10.0snapshot.2015.08.27
> ```
>
>
> Thanks,
>
> Bill Farner
>
>