You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2021/06/18 21:06:21 UTC
[GitHub] [cloudstack] davidjumani opened a new pull request #5128: tests: Skip test_persistent_networks if kvm and ovs
davidjumani opened a new pull request #5128:
URL: https://github.com/apache/cloudstack/pull/5128
### Description
Skips test_persistent_networks if the hypervisor is KVM and OVS is used as the network backend
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [x] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
#### Bug Severity
- [ ] BLOCKER
- [ ] Critical
- [ ] Major
- [x] Minor
- [ ] Trivial
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5128: tests: Skip test_persistent_networks if kvm and ovs
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5128:
URL: https://github.com/apache/cloudstack/pull/5128#issuecomment-868828437
<b>Trillian test result (tid-1099)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 43172 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5128-t1099-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
Smoke tests completed. 87 look OK, 1 have error(s)
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | `Failure` | 348.47 | test_vpc_redundant.py
test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers | `Error` | 3836.28 | test_vpc_redundant.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5128: tests: Skip test_persistent_networks if kvm and ovs
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5128:
URL: https://github.com/apache/cloudstack/pull/5128#issuecomment-869893387
<b>Trillian test result (tid-1130)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 36354 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5128-t1130-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_nic_adapter_type.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_vpn.py
Smoke tests completed. 88 look OK, 0 have error(s)
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5128: tests: Skip test_persistent_networks if kvm and ovs
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5128:
URL: https://github.com/apache/cloudstack/pull/5128#issuecomment-869420592
@davidjumani a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5128: tests: Skip test_persistent_networks if kvm and ovs
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5128:
URL: https://github.com/apache/cloudstack/pull/5128#issuecomment-868269798
@davidjumani a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sureshanaparti commented on pull request #5128: tests: Skip test_persistent_networks if kvm and ovs
Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on pull request #5128:
URL: https://github.com/apache/cloudstack/pull/5128#issuecomment-868317371
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez commented on a change in pull request #5128: tests: Skip test_persistent_networks if kvm and ovs
Posted by GitBox <gi...@apache.org>.
nvazquez commented on a change in pull request #5128:
URL: https://github.com/apache/cloudstack/pull/5128#discussion_r659112454
##########
File path: test/integration/smoke/test_persistent_network.py
##########
@@ -52,6 +52,22 @@ def setUpClass(cls):
cls.testClient = super(TestL2PersistentNetworks, cls).getClsTestClient()
cls.api_client = cls.testClient.getApiClient()
cls.hypervisor = cls.testClient.getHypervisorInfo()
+
+ isKVM = cls.hypervisor.lower() in ["kvm"]
+ isOVSEnabled = False
+ hostConfig = cls.config.__dict__["zones"][0].__dict__["pods"][0].__dict__["clusters"][0].__dict__["hosts"][0].__dict__
+ if isKVM :
+ # Test only if all the hosts use OVS
+ grepCmd = 'grep "network.bridge.type=openvswitch" /etc/cloudstack/agent/agent.properties'
+ hosts = list_hosts(cls.api_client, type='Routing', hypervisor='kvm')
+ if len(hosts) > 0 :
+ isOVSEnabled = True
+ for host in hosts :
+ isOVSEnabled = isOVSEnabled or len(SshClient(host.ipaddress, port=22, user=hostConfig["username"],
Review comment:
Ignore that, I see that `isOvsEnabled` is set to true if there are hosts. New question: why do we even check for the second part of the OR if the first part is always true? I think lines 63-64 can be removed and the lines 66-67 refactored to:
````
isOvsEnabled = len(SshClient(host.ipaddress, port=22, user=hostConfig["username"],passwd=hostConfig["password"]).execute(grepCmd)) != 0
if isOvsEnabled:
break
````
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez commented on pull request #5128: tests: Skip test_persistent_networks if kvm and ovs
Posted by GitBox <gi...@apache.org>.
nvazquez commented on pull request #5128:
URL: https://github.com/apache/cloudstack/pull/5128#issuecomment-870103554
LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5128: tests: Skip test_persistent_networks if kvm and ovs
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5128:
URL: https://github.com/apache/cloudstack/pull/5128#issuecomment-868318064
@sureshanaparti a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez merged pull request #5128: tests: Skip test_persistent_networks if kvm and ovs
Posted by GitBox <gi...@apache.org>.
nvazquez merged pull request #5128:
URL: https://github.com/apache/cloudstack/pull/5128
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5128: tests: Skip test_persistent_networks if kvm and ovs
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5128:
URL: https://github.com/apache/cloudstack/pull/5128#issuecomment-869397728
@davidjumani a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez commented on a change in pull request #5128: tests: Skip test_persistent_networks if kvm and ovs
Posted by GitBox <gi...@apache.org>.
nvazquez commented on a change in pull request #5128:
URL: https://github.com/apache/cloudstack/pull/5128#discussion_r659112454
##########
File path: test/integration/smoke/test_persistent_network.py
##########
@@ -52,6 +52,22 @@ def setUpClass(cls):
cls.testClient = super(TestL2PersistentNetworks, cls).getClsTestClient()
cls.api_client = cls.testClient.getApiClient()
cls.hypervisor = cls.testClient.getHypervisorInfo()
+
+ isKVM = cls.hypervisor.lower() in ["kvm"]
+ isOVSEnabled = False
+ hostConfig = cls.config.__dict__["zones"][0].__dict__["pods"][0].__dict__["clusters"][0].__dict__["hosts"][0].__dict__
+ if isKVM :
+ # Test only if all the hosts use OVS
+ grepCmd = 'grep "network.bridge.type=openvswitch" /etc/cloudstack/agent/agent.properties'
+ hosts = list_hosts(cls.api_client, type='Routing', hypervisor='kvm')
+ if len(hosts) > 0 :
+ isOVSEnabled = True
+ for host in hosts :
+ isOVSEnabled = isOVSEnabled or len(SshClient(host.ipaddress, port=22, user=hostConfig["username"],
Review comment:
Ignore that, I see that `isOvsEnabled` is set to true if there are hosts. New question: why do we even check for the second part of the OR if the first part is always true? The for loop may not be needed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] davidjumani commented on pull request #5128: tests: Skip test_persistent_networks if kvm and ovs
Posted by GitBox <gi...@apache.org>.
davidjumani commented on pull request #5128:
URL: https://github.com/apache/cloudstack/pull/5128#issuecomment-869397472
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5128: tests: Skip test_persistent_networks if kvm and ovs
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5128:
URL: https://github.com/apache/cloudstack/pull/5128#issuecomment-867933562
Packaging result: :heavy_check_mark: centos7 :heavy_check_mark: centos8 :heavy_check_mark: debian. SL-JID 359
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5128: tests: Skip test_persistent_networks if kvm and ovs
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5128:
URL: https://github.com/apache/cloudstack/pull/5128#issuecomment-869893387
<b>Trillian test result (tid-1130)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 36354 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5128-t1130-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_nic_adapter_type.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_vpn.py
Smoke tests completed. 88 look OK, 0 have error(s)
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez merged pull request #5128: tests: Skip test_persistent_networks if kvm and ovs
Posted by GitBox <gi...@apache.org>.
nvazquez merged pull request #5128:
URL: https://github.com/apache/cloudstack/pull/5128
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez commented on a change in pull request #5128: tests: Skip test_persistent_networks if kvm and ovs
Posted by GitBox <gi...@apache.org>.
nvazquez commented on a change in pull request #5128:
URL: https://github.com/apache/cloudstack/pull/5128#discussion_r659111764
##########
File path: test/integration/smoke/test_persistent_network.py
##########
@@ -52,6 +52,22 @@ def setUpClass(cls):
cls.testClient = super(TestL2PersistentNetworks, cls).getClsTestClient()
cls.api_client = cls.testClient.getApiClient()
cls.hypervisor = cls.testClient.getHypervisorInfo()
+
+ isKVM = cls.hypervisor.lower() in ["kvm"]
+ isOVSEnabled = False
+ hostConfig = cls.config.__dict__["zones"][0].__dict__["pods"][0].__dict__["clusters"][0].__dict__["hosts"][0].__dict__
+ if isKVM :
+ # Test only if all the hosts use OVS
+ grepCmd = 'grep "network.bridge.type=openvswitch" /etc/cloudstack/agent/agent.properties'
+ hosts = list_hosts(cls.api_client, type='Routing', hypervisor='kvm')
+ if len(hosts) > 0 :
+ isOVSEnabled = True
+ for host in hosts :
+ isOVSEnabled = isOVSEnabled or len(SshClient(host.ipaddress, port=22, user=hostConfig["username"],
Review comment:
If we want to ensure all hosts use OVS I think we need to add a check on the for loop and exit if `!isOVSEnabled`. Otherwise, we will only decide based on last host in the iteration
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5128: tests: Skip test_persistent_networks if kvm and ovs
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5128:
URL: https://github.com/apache/cloudstack/pull/5128#issuecomment-867934173
@nvazquez a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] davidjumani commented on pull request #5128: tests: Skip test_persistent_networks if kvm and ovs
Posted by GitBox <gi...@apache.org>.
davidjumani commented on pull request #5128:
URL: https://github.com/apache/cloudstack/pull/5128#issuecomment-869419872
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez commented on pull request #5128: tests: Skip test_persistent_networks if kvm and ovs
Posted by GitBox <gi...@apache.org>.
nvazquez commented on pull request #5128:
URL: https://github.com/apache/cloudstack/pull/5128#issuecomment-870103554
LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez commented on pull request #5128: tests: Skip test_persistent_networks if kvm and ovs
Posted by GitBox <gi...@apache.org>.
nvazquez commented on pull request #5128:
URL: https://github.com/apache/cloudstack/pull/5128#issuecomment-867933790
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5128: tests: Skip test_persistent_networks if kvm and ovs
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5128:
URL: https://github.com/apache/cloudstack/pull/5128#issuecomment-869419705
Packaging result: :heavy_check_mark: centos7 :heavy_check_mark: centos8 :heavy_check_mark: debian. SL-JID 387
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] davidjumani commented on pull request #5128: tests: Skip test_persistent_networks if kvm and ovs
Posted by GitBox <gi...@apache.org>.
davidjumani commented on pull request #5128:
URL: https://github.com/apache/cloudstack/pull/5128#issuecomment-868269489
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez commented on pull request #5128: tests: Skip test_persistent_networks if kvm and ovs
Posted by GitBox <gi...@apache.org>.
nvazquez commented on pull request #5128:
URL: https://github.com/apache/cloudstack/pull/5128#issuecomment-867909140
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5128: tests: Skip test_persistent_networks if kvm and ovs
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5128:
URL: https://github.com/apache/cloudstack/pull/5128#issuecomment-868282906
Packaging result: :heavy_check_mark: centos7 :heavy_check_mark: centos8 :heavy_check_mark: debian. SL-JID 366
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5128: tests: Skip test_persistent_networks if kvm and ovs
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5128:
URL: https://github.com/apache/cloudstack/pull/5128#issuecomment-867909248
@nvazquez a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5128: tests: Skip test_persistent_networks if kvm and ovs
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5128:
URL: https://github.com/apache/cloudstack/pull/5128#issuecomment-868265442
<b>Trillian test result (tid-1094)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 34654 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5128-t1094-kvm-centos7.zip
Smoke tests completed. 88 look OK, 0 have error(s)
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org