You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@maven.apache.org by jd...@apache.org on 2006/03/27 19:15:43 UTC

svn commit: r389201 - in /maven/components/branches/maven-2.0.x/maven-project/src: main/java/org/apache/maven/project/MavenProject.java test/java/org/apache/maven/project/MavenProjectTest.java

Author: jdcasey
Date: Mon Mar 27 09:15:40 2006
New Revision: 389201

URL: http://svn.apache.org/viewcvs?rev=389201&view=rev
Log:
Fixing empty constructor to avoid NPEs in resulting MavenProject.

Modified:
    maven/components/branches/maven-2.0.x/maven-project/src/main/java/org/apache/maven/project/MavenProject.java
    maven/components/branches/maven-2.0.x/maven-project/src/test/java/org/apache/maven/project/MavenProjectTest.java

Modified: maven/components/branches/maven-2.0.x/maven-project/src/main/java/org/apache/maven/project/MavenProject.java
URL: http://svn.apache.org/viewcvs/maven/components/branches/maven-2.0.x/maven-project/src/main/java/org/apache/maven/project/MavenProject.java?rev=389201&r1=389200&r2=389201&view=diff
==============================================================================
--- maven/components/branches/maven-2.0.x/maven-project/src/main/java/org/apache/maven/project/MavenProject.java (original)
+++ maven/components/branches/maven-2.0.x/maven-project/src/main/java/org/apache/maven/project/MavenProject.java Mon Mar 27 09:15:40 2006
@@ -77,6 +77,12 @@
  */
 public class MavenProject
 {
+    public static final String EMPTY_PROJECT_GROUP_ID = "unknown";
+    
+    public static final String EMPTY_PROJECT_ARTIFACT_ID = "empty-project";
+    
+    public static final String EMPTY_PROJECT_VERSION = "0";
+    
     private Model model;
 
     private MavenProject parent;
@@ -140,6 +146,13 @@
 
     public MavenProject()
     {
+        Model model = new Model();
+        
+        model.setGroupId( EMPTY_PROJECT_GROUP_ID );
+        model.setArtifactId( EMPTY_PROJECT_ARTIFACT_ID );
+        model.setVersion( EMPTY_PROJECT_VERSION );
+        
+        this.model = model;
     }
 
     public MavenProject( Model model )

Modified: maven/components/branches/maven-2.0.x/maven-project/src/test/java/org/apache/maven/project/MavenProjectTest.java
URL: http://svn.apache.org/viewcvs/maven/components/branches/maven-2.0.x/maven-project/src/test/java/org/apache/maven/project/MavenProjectTest.java?rev=389201&r1=389200&r2=389201&view=diff
==============================================================================
--- maven/components/branches/maven-2.0.x/maven-project/src/test/java/org/apache/maven/project/MavenProjectTest.java (original)
+++ maven/components/branches/maven-2.0.x/maven-project/src/test/java/org/apache/maven/project/MavenProjectTest.java Mon Mar 27 09:15:40 2006
@@ -24,6 +24,15 @@
 public class MavenProjectTest
     extends AbstractMavenProjectTestCase
 {
+    
+    public void testEmptyConstructor()
+    {
+        MavenProject project = new MavenProject();
+        
+        assertEquals( MavenProject.EMPTY_PROJECT_GROUP_ID + ":" + MavenProject.EMPTY_PROJECT_ARTIFACT_ID + ":jar:"
+            + MavenProject.EMPTY_PROJECT_VERSION, project.getId() );
+    }
+    
     public void testCopyConstructor() throws Exception
     {
         File f = getFileForClasspathResource( "canonical-pom.xml" );