[GitHub] [nifi-minifi-cpp] szaszm commented on a change in pull request #858: MINIFICPP-1300 - Decouple ControllerServiceProvider ownerships from use-only components

[GitBox <gi...@apache.org>]

szaszm commented on a change in pull request #858:
URL: https://github.com/apache/nifi-minifi-cpp/pull/858#discussion_r469362669



##########
File path: nanofi/include/cxx/Instance.h
##########
@@ -134,7 +134,7 @@ class Instance {
 
   void transfer(const std::shared_ptr<FlowFileRecord> &ff, const std::shared_ptr<minifi::io::DataStream> &stream = nullptr) {
     std::shared_ptr<core::controller::ControllerServiceProvider> controller_service_provider = nullptr;
-    auto processContext = std::make_shared<core::ProcessContext>(proc_node_, controller_service_provider, no_op_repo_, no_op_repo_, configure_, content_repo_);
+    auto processContext = std::make_shared<core::ProcessContext>(proc_node_, controller_service_provider.get(), no_op_repo_, no_op_repo_, configure_, content_repo_);

Review comment:
       Why no `nullptr` substitution in this file?

##########
File path: libminifi/include/core/ProcessContextBuilder.h
##########
@@ -40,6 +40,7 @@
 #include "core/Repository.h"
 #include "core/FlowFile.h"
 #include "VariableRegistry.h"
+#include "utils/gsl.h"

Review comment:
       I think this include is not necessary, probably a leftover from a previous development version.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org