You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@solr.apache.org by GitBox <gi...@apache.org> on 2022/09/19 14:26:04 UTC
[GitHub] [solr] gerlowskija opened a new pull request, #1023: Refactor way ApiRegistrar class
gerlowskija opened a new pull request, #1023:
URL: https://github.com/apache/solr/pull/1023
https://issues.apache.org/jira/browse/SOLR-XXXXX
<!--
_(If you are a project committer then you may remove some/all of the following template.)_
Before creating a pull request, please file an issue in the ASF Jira system for Solr:
* https://issues.apache.org/jira/projects/SOLR
For something minor (i.e. that wouldn't be worth putting in release notes), you can skip JIRA.
To create a Jira issue, you will need to create an account there first.
The title of the PR should reference the Jira issue number in the form:
* SOLR-####: <short description of problem or changes>
SOLR must be fully capitalized. A short description helps people scanning pull requests for items they can work on.
Properly referencing the issue in the title ensures that Jira is correctly updated with code review comments and commits. -->
# Description
Earlier on during v2 API refactoring, I had created ApiRegistrar as a
way to bundle together the registration of API classes that were
multiplying and cluttering up CoreContainer.load.
In hindsight, this was based on a misunderstanding that there was a
reason to register APIs (directly) in CoreContainer.load in the first
place. But there's not: both core and container-level APIs can be
registered just fine via the 'getApis()' method present on their
associated requestHandler. The only APIs that cannot use this approach,
and must be registered explicitly in CoreContainer.load are those v2
APIs that don't have a v1/requestHandler equivalent.
# Solution
With this in mind, I'm removing my ill-conceived attempt at an
ApiRegistrar class, to simplify the overall picture for API
registration.
# Tests
N/A - change is a refactor only, so existing tests must continue to pass.
# Checklist
Please review the following and check all that apply:
- [x] I have reviewed the guidelines for [How to Contribute](https://wiki.apache.org/solr/HowToContribute) and my code conforms to the standards described there to the best of my ability.
- [x] I have given Solr maintainers [access](https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork) to contribute to my PR branch. (optional but recommended)
- [x] I have developed this patch against the `main` branch.
- [x] I have run `./gradlew check`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] gerlowskija merged pull request #1023: Refactor way ApiRegistrar class
Posted by GitBox <gi...@apache.org>.
gerlowskija merged PR #1023:
URL: https://github.com/apache/solr/pull/1023
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org