You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2020/12/18 09:47:34 UTC

[GitHub] [apisix-ingress-controller] Firstsawyou opened a new pull request #109: docs: the install.md doc lacks the creation of namespaces "ingress-apisix"

Firstsawyou opened a new pull request #109:
URL: https://github.com/apache/apisix-ingress-controller/pull/109


   fix #108


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-ingress-controller] gxthrj merged pull request #109: docs: the install.md doc lacks the creation of namespaces "ingress-apisix"

Posted by GitBox <gi...@apache.org>.
gxthrj merged pull request #109:
URL: https://github.com/apache/apisix-ingress-controller/pull/109


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-ingress-controller] codecov-io commented on pull request #109: docs: the install.md doc lacks the creation of namespaces "ingress-apisix"

Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #109:
URL: https://github.com/apache/apisix-ingress-controller/pull/109#issuecomment-748084604


   # [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/109?src=pr&el=h1) Report
   > Merging [#109](https://codecov.io/gh/apache/apisix-ingress-controller/pull/109?src=pr&el=desc) (f7d834b) into [master](https://codecov.io/gh/apache/apisix-ingress-controller/commit/ef552b8ba799c907f9205a7952b28a7b42286d37?el=desc) (ef552b8) will **not change** coverage.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/apisix-ingress-controller/pull/109/graphs/tree.svg?width=650&height=150&src=pr&token=WPLQXPY3V0)](https://codecov.io/gh/apache/apisix-ingress-controller/pull/109?src=pr&el=tree)
   
   ```diff
   @@           Coverage Diff           @@
   ##           master     #109   +/-   ##
   =======================================
     Coverage   60.53%   60.53%           
   =======================================
     Files          16       16           
     Lines         527      527           
   =======================================
     Hits          319      319           
     Misses        184      184           
     Partials       24       24           
   ```
   
   
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/109?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/109?src=pr&el=footer). Last update [ef552b8...f7d834b](https://codecov.io/gh/apache/apisix-ingress-controller/pull/109?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-ingress-controller] tokers commented on a change in pull request #109: docs: the install.md doc lacks the creation of namespaces "ingress-apisix"

Posted by GitBox <gi...@apache.org>.
tokers commented on a change in pull request #109:
URL: https://github.com/apache/apisix-ingress-controller/pull/109#discussion_r545788404



##########
File path: docs/install.md
##########
@@ -34,6 +34,12 @@ To install `ingress controller` in k8s, need to care about 3 parts:
 
 ## Kustomize
 
+Before executing the following command, you need to create the namespace `ingress-apisix`:

Review comment:
       use plural commands.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-ingress-controller] Firstsawyou commented on a change in pull request #109: docs: the install.md doc lacks the creation of namespaces "ingress-apisix"

Posted by GitBox <gi...@apache.org>.
Firstsawyou commented on a change in pull request #109:
URL: https://github.com/apache/apisix-ingress-controller/pull/109#discussion_r545830660



##########
File path: docs/install.md
##########
@@ -34,6 +34,12 @@ To install `ingress controller` in k8s, need to care about 3 parts:
 
 ## Kustomize
 
+Before executing the following command, you need to create the namespace `ingress-apisix`:

Review comment:
       updated.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org