[GitHub] [pinot] Jackie-Jiang commented on a change in pull request #8263: Bugfix for order-by all sorted optimization

[GitBox <gi...@apache.org>]

Jackie-Jiang commented on a change in pull request #8263:
URL: https://github.com/apache/pinot/pull/8263#discussion_r816199384



##########
File path: pinot-core/src/main/java/org/apache/pinot/core/plan/SelectionPlanNode.java
##########
@@ -56,14 +56,16 @@ public SelectionPlanNode(IndexSegment indexSegment, QueryContext queryContext) {
       if (orderByExpressions == null) {
         // Selection only
         TransformOperator transformOperator = new TransformPlanNode(_indexSegment, _queryContext, expressions,
-            Math.min(limit + _queryContext.getOffset(), DocIdSetPlanNode.MAX_DOC_PER_CALL)).run();
+            Math.min(limit, DocIdSetPlanNode.MAX_DOC_PER_CALL)).run();

Review comment:
       Without order-by, should scan `limit` records




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org