You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@calcite.apache.org by GitBox <gi...@apache.org> on 2020/06/04 03:08:49 UTC
[GitHub] [calcite] jinxing64 commented on a change in pull request #2000: [CALCITE-4040] Nonstandard SqlAggFunction rollup Exception
jinxing64 commented on a change in pull request #2000:
URL: https://github.com/apache/calcite/pull/2000#discussion_r434966705
##########
File path: core/src/test/java/org/apache/calcite/test/MaterializedViewSubstitutionVisitorTest.java
##########
@@ -410,6 +410,18 @@
sql(mv, query).noMat();
}
Review comment:
How about some doc here to explain why matching should fail.
##########
File path: core/src/main/java/org/apache/calcite/plan/SubstitutionVisitor.java
##########
@@ -1899,8 +1899,12 @@ public static MutableRel unifyAggregates(MutableAggregate query,
if (i < 0) {
return null;
}
+ SqlAggFunction aggFunction = getRollup(aggregateCall.getAggregation());
Review comment:
How about some doc to explain why matching should fail when the function doesn't support roll-up.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org