You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sqoop.apache.org by Bilung Lee <bl...@gmail.com> on 2012/10/18 20:47:13 UTC

Review Request: SQOOP-610 Job submission engine for import

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7492/
-----------------------------------------------------------

Review request for Sqoop.


Description
-------

MapReduce submission engine for import.


This addresses bug SQOOP-610.
    https://issues.apache.org/jira/browse/SQOOP-610


Diffs
-----

  core/src/main/java/org/apache/sqoop/job/JobConstants.java a032c72 
  core/src/main/java/org/apache/sqoop/job/JobEngine.java PRE-CREATION 
  core/src/main/java/org/apache/sqoop/job/etl/EtlFramework.java PRE-CREATION 
  core/src/main/java/org/apache/sqoop/job/etl/EtlOptions.java PRE-CREATION 
  core/src/main/java/org/apache/sqoop/job/mr/MrExecution.java PRE-CREATION 
  core/src/main/java/org/apache/sqoop/job/mr/SqoopReducer.java PRE-CREATION 
  core/src/test/java/org/apache/sqoop/job/TestJobEngine.java PRE-CREATION 

Diff: https://reviews.apache.org/r/7492/diff/


Testing
-------


Thanks,

Bilung Lee

Re: Review Request: SQOOP-610 Job submission engine for import

Posted by Jarek Cecho <ja...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7492/#review12620
-----------------------------------------------------------

Ship it!


Thank you very much for your time Bilung. Please attach your patch to the JIRA and I'll commit it.

Jarcec

- Jarek Cecho


On Oct. 19, 2012, 6:48 p.m., Bilung Lee wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/7492/
> -----------------------------------------------------------
> 
> (Updated Oct. 19, 2012, 6:48 p.m.)
> 
> 
> Review request for Sqoop.
> 
> 
> Description
> -------
> 
> MapReduce submission engine for import.
> 
> 
> This addresses bug SQOOP-610.
>     https://issues.apache.org/jira/browse/SQOOP-610
> 
> 
> Diffs
> -----
> 
>   core/src/main/java/org/apache/sqoop/job/JobConstants.java a032c72 
>   core/src/main/java/org/apache/sqoop/job/JobEngine.java PRE-CREATION 
>   core/src/main/java/org/apache/sqoop/job/etl/EtlFramework.java PRE-CREATION 
>   core/src/main/java/org/apache/sqoop/job/etl/EtlOptions.java PRE-CREATION 
>   core/src/main/java/org/apache/sqoop/job/mr/MrExecution.java PRE-CREATION 
>   core/src/main/java/org/apache/sqoop/job/mr/SqoopReducer.java PRE-CREATION 
>   core/src/test/java/org/apache/sqoop/job/TestJobEngine.java PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/7492/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Bilung Lee
> 
>

Re: Review Request: SQOOP-610 Job submission engine for import

Posted by Bilung Lee <bl...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7492/
-----------------------------------------------------------

(Updated Oct. 19, 2012, 6:48 p.m.)


Review request for Sqoop.


Changes
-------

A new patch is provided to base on the recently checked in code.


Description
-------

MapReduce submission engine for import.


This addresses bug SQOOP-610.
    https://issues.apache.org/jira/browse/SQOOP-610


Diffs (updated)
-----

  core/src/main/java/org/apache/sqoop/job/JobConstants.java a032c72 
  core/src/main/java/org/apache/sqoop/job/JobEngine.java PRE-CREATION 
  core/src/main/java/org/apache/sqoop/job/etl/EtlFramework.java PRE-CREATION 
  core/src/main/java/org/apache/sqoop/job/etl/EtlOptions.java PRE-CREATION 
  core/src/main/java/org/apache/sqoop/job/mr/MrExecution.java PRE-CREATION 
  core/src/main/java/org/apache/sqoop/job/mr/SqoopReducer.java PRE-CREATION 
  core/src/test/java/org/apache/sqoop/job/TestJobEngine.java PRE-CREATION 

Diff: https://reviews.apache.org/r/7492/diff/


Testing
-------


Thanks,

Bilung Lee

Re: Review Request: SQOOP-610 Job submission engine for import

Posted by Jarek Cecho <ja...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7492/#review12603
-----------------------------------------------------------


Hi Bilung, 
the patch seems fine to me. Could you just update it for current version of the sqoop2 branch? I was getting compilation errors in tests due to changed SqoopConnector interface.

Jarcec

- Jarek Cecho


On Oct. 18, 2012, 6:47 p.m., Bilung Lee wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/7492/
> -----------------------------------------------------------
> 
> (Updated Oct. 18, 2012, 6:47 p.m.)
> 
> 
> Review request for Sqoop.
> 
> 
> Description
> -------
> 
> MapReduce submission engine for import.
> 
> 
> This addresses bug SQOOP-610.
>     https://issues.apache.org/jira/browse/SQOOP-610
> 
> 
> Diffs
> -----
> 
>   core/src/main/java/org/apache/sqoop/job/JobConstants.java a032c72 
>   core/src/main/java/org/apache/sqoop/job/JobEngine.java PRE-CREATION 
>   core/src/main/java/org/apache/sqoop/job/etl/EtlFramework.java PRE-CREATION 
>   core/src/main/java/org/apache/sqoop/job/etl/EtlOptions.java PRE-CREATION 
>   core/src/main/java/org/apache/sqoop/job/mr/MrExecution.java PRE-CREATION 
>   core/src/main/java/org/apache/sqoop/job/mr/SqoopReducer.java PRE-CREATION 
>   core/src/test/java/org/apache/sqoop/job/TestJobEngine.java PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/7492/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Bilung Lee
> 
>