You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2022/04/21 01:54:28 UTC

[GitHub] [apisix-ingress-controller] AlinsRan commented on a diff in pull request #975: feat: update an redirect annotation for ingress resource

AlinsRan commented on code in PR #975:
URL: https://github.com/apache/apisix-ingress-controller/pull/975#discussion_r854708977


##########
pkg/kube/translation/annotations/redirect.go:
##########
@@ -15,11 +15,15 @@
 package annotations
 
 import (
+	"strconv"
+
 	apisixv1 "github.com/apache/apisix-ingress-controller/pkg/types/apisix/v1"
 )
 
 const (
 	_httpToHttps = AnnotationsPrefix + "http-to-https"
+	_uri         = AnnotationsPrefix + "uri"
+	_retCode     = AnnotationsPrefix + "ret_code"

Review Comment:
   got it, I think so, too.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org