You are viewing a plain text version of this content. The canonical link for it is here.
Posted to ivy-commits@incubator.apache.org by "Xavier Hanin (JIRA)" <ji...@apache.org> on 2007/03/17 10:10:09 UTC

[jira] Created: (IVY-437) setting m2compatible on ibiblio resolver overwrite root and pattern settings

setting m2compatible on ibiblio resolver overwrite root and pattern settings
----------------------------------------------------------------------------

                 Key: IVY-437
                 URL: https://issues.apache.org/jira/browse/IVY-437
             Project: Ivy
          Issue Type: Bug
    Affects Versions: 1.4.1
            Reporter: Xavier Hanin
             Fix For: 1.5


Setting m2compatible="true" on an ibiblio resolver overwrites the root and pattern settings, even if they were set manually. Depending on the order of attributes and the xml parser used, the result is varying (if setM2compatible is called before setRoot, the configured root will be used, otherwise it's the default value for m2compatible which will be used!

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (IVY-437) setting m2compatible on ibiblio resolver overwrite root and pattern settings

Posted by "Xavier Hanin (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/IVY-437?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Xavier Hanin resolved IVY-437.
------------------------------

    Resolution: Fixed

Updated junit test and fixed the problem. Now the manual settings will be used even if setM2compatible is called after setRoot or setPattern

> setting m2compatible on ibiblio resolver overwrite root and pattern settings
> ----------------------------------------------------------------------------
>
>                 Key: IVY-437
>                 URL: https://issues.apache.org/jira/browse/IVY-437
>             Project: Ivy
>          Issue Type: Bug
>    Affects Versions: 1.4.1
>            Reporter: Xavier Hanin
>         Assigned To: Xavier Hanin
>             Fix For: 1.5
>
>
> Setting m2compatible="true" on an ibiblio resolver overwrites the root and pattern settings, even if they were set manually. Depending on the order of attributes and the xml parser used, the result is varying (if setM2compatible is called before setRoot, the configured root will be used, otherwise it's the default value for m2compatible which will be used!

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Reopened: (IVY-437) setting m2compatible on ibiblio resolver overwrite root and pattern settings

Posted by "Maarten Coene (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/IVY-437?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Maarten Coene reopened IVY-437:
-------------------------------

      Assignee:     (was: Xavier Hanin)

I'm reopening this for further investigation

> setting m2compatible on ibiblio resolver overwrite root and pattern settings
> ----------------------------------------------------------------------------
>
>                 Key: IVY-437
>                 URL: https://issues.apache.org/jira/browse/IVY-437
>             Project: Ivy
>          Issue Type: Bug
>    Affects Versions: 1.4.1
>            Reporter: Xavier Hanin
>             Fix For: 2.0.0-alpha-1
>
>         Attachments: m2root_override.patch
>
>
> Setting m2compatible="true" on an ibiblio resolver overwrites the root and pattern settings, even if they were set manually. Depending on the order of attributes and the xml parser used, the result is varying (if setM2compatible is called before setRoot, the configured root will be used, otherwise it's the default value for m2compatible which will be used!

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Assigned: (IVY-437) setting m2compatible on ibiblio resolver overwrite root and pattern settings

Posted by "Xavier Hanin (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/IVY-437?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Xavier Hanin reassigned IVY-437:
--------------------------------

    Assignee: Xavier Hanin

> setting m2compatible on ibiblio resolver overwrite root and pattern settings
> ----------------------------------------------------------------------------
>
>                 Key: IVY-437
>                 URL: https://issues.apache.org/jira/browse/IVY-437
>             Project: Ivy
>          Issue Type: Bug
>    Affects Versions: 1.4.1
>            Reporter: Xavier Hanin
>         Assigned To: Xavier Hanin
>             Fix For: 1.5
>
>
> Setting m2compatible="true" on an ibiblio resolver overwrites the root and pattern settings, even if they were set manually. Depending on the order of attributes and the xml parser used, the result is varying (if setM2compatible is called before setRoot, the configured root will be used, otherwise it's the default value for m2compatible which will be used!

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (IVY-437) setting m2compatible on ibiblio resolver overwrite root and pattern settings

Posted by "Jing Xue (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/IVY-437?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12511821 ] 

Jing Xue commented on IVY-437:
------------------------------

Actually, I'm not sure this is fixed.  Now (as of r555145) the configured value is ignored when setM2compatible is called _before_ others. 8-)

This was discovered when I tried to build the latest ivy trunk code, and because ivysettings.xml is no longer used, I added ivy.ibiblio.default.artifact.root to build.properties, which apparently didn't take an effect.

I'm attaching a patch to IBiblioResolver.java that appears to fix the problem - at least I'm able to build the trunk with it.

> setting m2compatible on ibiblio resolver overwrite root and pattern settings
> ----------------------------------------------------------------------------
>
>                 Key: IVY-437
>                 URL: https://issues.apache.org/jira/browse/IVY-437
>             Project: Ivy
>          Issue Type: Bug
>    Affects Versions: 1.4.1
>            Reporter: Xavier Hanin
>            Assignee: Xavier Hanin
>             Fix For: 2.0.0-alpha-1
>
>         Attachments: m2root_override.patch
>
>
> Setting m2compatible="true" on an ibiblio resolver overwrites the root and pattern settings, even if they were set manually. Depending on the order of attributes and the xml parser used, the result is varying (if setM2compatible is called before setRoot, the configured root will be used, otherwise it's the default value for m2compatible which will be used!

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (IVY-437) setting m2compatible on ibiblio resolver overwrite root and pattern settings

Posted by "Jing Xue (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/IVY-437?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jing Xue updated IVY-437:
-------------------------

    Attachment: m2root_override.patch

> setting m2compatible on ibiblio resolver overwrite root and pattern settings
> ----------------------------------------------------------------------------
>
>                 Key: IVY-437
>                 URL: https://issues.apache.org/jira/browse/IVY-437
>             Project: Ivy
>          Issue Type: Bug
>    Affects Versions: 1.4.1
>            Reporter: Xavier Hanin
>            Assignee: Xavier Hanin
>             Fix For: 2.0.0-alpha-1
>
>         Attachments: m2root_override.patch
>
>
> Setting m2compatible="true" on an ibiblio resolver overwrites the root and pattern settings, even if they were set manually. Depending on the order of attributes and the xml parser used, the result is varying (if setM2compatible is called before setRoot, the configured root will be used, otherwise it's the default value for m2compatible which will be used!

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.