[GitHub] [airflow] uranusjr commented on a diff in pull request #33675: Refactor: Improve detection of duplicates and list sorting

["uranusjr (via GitHub)" <gi...@apache.org>]

uranusjr commented on code in PR #33675:
URL: https://github.com/apache/airflow/pull/33675#discussion_r1303667390


##########
airflow/example_dags/example_params_trigger_ui.py:
##########
@@ -33,7 +33,7 @@
 
 with DAG(
     dag_id=Path(__file__).stem,
-    description=__doc__[0 : __doc__.find(".")],
+    description=__doc__.partition(".")[0],

Review Comment:
   Not totally related but gosh I’m not sure we should encourage this pattern.



##########
airflow/example_dags/example_params_trigger_ui.py:
##########
@@ -33,7 +33,7 @@
 
 with DAG(
     dag_id=Path(__file__).stem,
-    description=__doc__[0 : __doc__.find(".")],
+    description=__doc__.partition(".")[0],

Review Comment:
   Not totally related but gosh I’m not sure we should encourage this pattern.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org