[GitHub] [openwhisk] ruediger-maass commented on a change in pull request #4715: Extension points for kamon metric key generator and reporter

[GitBox <gi...@apache.org>]

ruediger-maass commented on a change in pull request #4715: Extension points for kamon metric key generator and reporter
URL: https://github.com/apache/openwhisk/pull/4715#discussion_r344013868
 
 

 ##########
 File path: common/scala/src/main/resources/application.conf
 ##########
 @@ -61,7 +61,9 @@ kamon {
             dispatcher =  [ "*" ]
         }
 
+        # Extension point for metrics key generator
         metric-key-generator = org.apache.openwhisk.common.WhiskStatsDMetricKeyGenerator
+        metric-key-generator = ${?KAMON_STATSD_METRIC_KEY_GENERATOR}
 
 Review comment:
   Thanks, Chetan! Yes, the reporter we need is an extension of the Kamon statsd reporter. If the CONFIG_kamon_... mechanism works for both settings we need in `application.conf` then of course I would not add additional variables - I thought I have to do this when I looked at METRICS_KAMON_TAGS and other variables in `application.conf`. I can check your proposal next Tuesday and come back. Maybe we do not need any code changes then and can withdraw this PR. Thank you for helpful hint!

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services