You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ws.apache.org by GitBox <gi...@apache.org> on 2022/04/21 17:06:13 UTC
[GitHub] [ws-wss4j] reta opened a new pull request, #50: Update Ehcache to 3.10.0
reta opened a new pull request, #50:
URL: https://github.com/apache/ws-wss4j/pull/50
@coheigea seems like https://github.com/apache/ws-wss4j/commit/e4a33efcb2b474a1da2b2c08f815b2718e111823 fixes repositories issue
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@ws.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ws.apache.org
For additional commands, e-mail: dev-help@ws.apache.org
[GitHub] [ws-wss4j] reta commented on pull request #50: Update Ehcache to 3.10.0
Posted by GitBox <gi...@apache.org>.
reta commented on PR #50:
URL: https://github.com/apache/ws-wss4j/pull/50#issuecomment-1106455413
Oh yeah, this is the Jakarta-compatible version, updated, thanks @coheigea !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@ws.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ws.apache.org
For additional commands, e-mail: dev-help@ws.apache.org
[GitHub] [ws-wss4j] coheigea merged pull request #50: Update Ehcache to 3.10.0
Posted by GitBox <gi...@apache.org>.
coheigea merged PR #50:
URL: https://github.com/apache/ws-wss4j/pull/50
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@ws.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ws.apache.org
For additional commands, e-mail: dev-help@ws.apache.org
[GitHub] [ws-wss4j] coheigea commented on pull request #50: Update Ehcache to 3.10.0
Posted by GitBox <gi...@apache.org>.
coheigea commented on PR #50:
URL: https://github.com/apache/ws-wss4j/pull/50#issuecomment-1106080916
Thanks @reta . Should it have the jakarta classifier? I see:
[INFO] +- org.ehcache:ehcache:jar:3.10.0:compile (optional)
[INFO] | \- javax.cache:cache-api:jar:1.1.0:compile (optional)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@ws.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ws.apache.org
For additional commands, e-mail: dev-help@ws.apache.org
[GitHub] [ws-wss4j] reta commented on a diff in pull request #50: Update Ehcache to 3.10.0
Posted by GitBox <gi...@apache.org>.
reta commented on code in PR #50:
URL: https://github.com/apache/ws-wss4j/pull/50#discussion_r855430534
##########
.github/workflows/codeql-analysis.yml:
##########
@@ -36,11 +36,6 @@ jobs:
# a pull request then we can checkout the head.
fetch-depth: 2
- # If this run was triggered by a pull request event, then checkout
- # the head of the pull request instead of the merge commit.
- - run: git checkout HEAD^2
Review Comment:
```
Run github/codeql-action/init@v1
Warning: 1 issue was detected with this workflow: git checkout HEAD^2 is no longer necessary. Please remove this step as Code Scanning recommends analyzing the merge commit for best results.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@ws.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ws.apache.org
For additional commands, e-mail: dev-help@ws.apache.org
[GitHub] [ws-wss4j] jimma commented on pull request #50: Update Ehcache to 3.10.0
Posted by GitBox <gi...@apache.org>.
jimma commented on PR #50:
URL: https://github.com/apache/ws-wss4j/pull/50#issuecomment-1106472170
Thanks the change, @reta and @coheigea ! This will fix the test failure in CXF without the ehcache exclusion for wss4j dependency:
```
Caused by: java.lang.NoClassDefFoundError: javax/xml/bind/ValidationEventHandler
at org.ehcache.xml.XmlConfiguration.<init>(XmlConfiguration.java:114)
at org.apache.cxf.ws.security.tokenstore.EHCacheTokenStore.<init>(EHCacheTokenStore.java:69)
at org.apache.cxf.sts.cache.DefaultInMemoryTokenStore.<init>(DefaultInMemoryTokenStore.java:36)
at java.base/jdk.internal.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method)
at java.base/jdk.internal.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:77)
at java.base/jdk.internal.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
at java.base/java.lang.reflect.Constructor.newInstanceWithCaller(Constructor.java:499)
at java.base/java.lang.reflect.Constructor.newInstance(Constructor.java:480)
at org.springframework.beans.BeanUtils.instantiateClass(BeanUtils.java:206)
... 59 more
```
I saw this PR until I submitted my PR to do the same thing. I already closed mine. There is a jira for this upgrade: https://issues.apache.org/jira/browse/WSS-696. Feel free to close it if it's not needed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@ws.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ws.apache.org
For additional commands, e-mail: dev-help@ws.apache.org