You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/02/04 08:47:12 UTC
[GitHub] [spark] MaxGekk opened a new pull request #27448: [MINOR][SQL] Make
legacy SQL configs as internal configs
MaxGekk opened a new pull request #27448: [MINOR][SQL] Make legacy SQL configs as internal configs
URL: https://github.com/apache/spark/pull/27448
### What changes were proposed in this pull request?
All legacy SQL configs are marked as internal configs. In particular, the following configs are updated as internals:
- spark.sql.legacy.sizeOfNull
- spark.sql.legacy.replaceDatabricksSparkAvro.enabled
- spark.sql.legacy.typeCoercion.datetimeToString.enabled
- spark.sql.legacy.looseUpcast
- spark.sql.legacy.arrayExistsFollowsThreeValuedLogic
### Why are the changes needed?
In general case, users shouldn't change legacy configs, so, they can be marked as internals.
### Does this PR introduce any user-facing change?
No
### How was this patch tested?
Should be tested by jenkins build and run tests.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #27448:
[SPARK-30725][SQL] Make legacy SQL configs as internal configs
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #27448: [SPARK-30725][SQL] Make legacy SQL configs as internal configs
URL: https://github.com/apache/spark/pull/27448#issuecomment-581804445
**[Test build #117823 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/117823/testReport)** for PR 27448 at commit [`aa8b8d9`](https://github.com/apache/spark/commit/aa8b8d95999a55b87a03cfd412ad29077d30e14a).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27448:
[SPARK-30725][SQL] Make legacy SQL configs as internal configs
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27448: [SPARK-30725][SQL] Make legacy SQL configs as internal configs
URL: https://github.com/apache/spark/pull/27448#issuecomment-581897476
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on issue #27448: [SPARK-30725][SQL]
Make legacy SQL configs as internal configs
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on issue #27448: [SPARK-30725][SQL] Make legacy SQL configs as internal configs
URL: https://github.com/apache/spark/pull/27448#issuecomment-581904979
thanks, merging to master/3.0!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27448: [MINOR][SQL] Make legacy
SQL configs as internal configs
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27448: [MINOR][SQL] Make legacy SQL configs as internal configs
URL: https://github.com/apache/spark/pull/27448#issuecomment-581804445
**[Test build #117823 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/117823/testReport)** for PR 27448 at commit [`aa8b8d9`](https://github.com/apache/spark/commit/aa8b8d95999a55b87a03cfd412ad29077d30e14a).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27448:
[MINOR][SQL] Make legacy SQL configs as internal configs
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27448: [MINOR][SQL] Make legacy SQL configs as internal configs
URL: https://github.com/apache/spark/pull/27448#issuecomment-581819116
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/22586/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27448: [SPARK-30725][SQL]
Make legacy SQL configs as internal configs
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27448: [SPARK-30725][SQL] Make legacy SQL configs as internal configs
URL: https://github.com/apache/spark/pull/27448#issuecomment-581897476
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27448: [MINOR][SQL] Make
legacy SQL configs as internal configs
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27448: [MINOR][SQL] Make legacy SQL configs as internal configs
URL: https://github.com/apache/spark/pull/27448#issuecomment-581819106
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan closed pull request #27448: [SPARK-30725][SQL]
Make legacy SQL configs as internal configs
Posted by GitBox <gi...@apache.org>.
cloud-fan closed pull request #27448: [SPARK-30725][SQL] Make legacy SQL configs as internal configs
URL: https://github.com/apache/spark/pull/27448
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27448: [SPARK-30725][SQL]
Make legacy SQL configs as internal configs
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27448: [SPARK-30725][SQL] Make legacy SQL configs as internal configs
URL: https://github.com/apache/spark/pull/27448#issuecomment-581897482
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/117823/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk commented on issue #27448: [MINOR][SQL] Make legacy
SQL configs as internal configs
Posted by GitBox <gi...@apache.org>.
MaxGekk commented on issue #27448: [MINOR][SQL] Make legacy SQL configs as internal configs
URL: https://github.com/apache/spark/pull/27448#issuecomment-581802474
@cloud-fan Please, take a look at this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27448: [MINOR][SQL] Make
legacy SQL configs as internal configs
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27448: [MINOR][SQL] Make legacy SQL configs as internal configs
URL: https://github.com/apache/spark/pull/27448#issuecomment-581819116
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/22586/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27448:
[MINOR][SQL] Make legacy SQL configs as internal configs
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27448: [MINOR][SQL] Make legacy SQL configs as internal configs
URL: https://github.com/apache/spark/pull/27448#issuecomment-581819106
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27448: [SPARK-30725][SQL] Make
legacy SQL configs as internal configs
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27448: [SPARK-30725][SQL] Make legacy SQL configs as internal configs
URL: https://github.com/apache/spark/pull/27448#issuecomment-581896892
**[Test build #117823 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/117823/testReport)** for PR 27448 at commit [`aa8b8d9`](https://github.com/apache/spark/commit/aa8b8d95999a55b87a03cfd412ad29077d30e14a).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27448:
[SPARK-30725][SQL] Make legacy SQL configs as internal configs
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27448: [SPARK-30725][SQL] Make legacy SQL configs as internal configs
URL: https://github.com/apache/spark/pull/27448#issuecomment-581897482
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/117823/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org