[GitHub] [incubator-pekko] mdedetrich commented on issue #210: Create sbt plugin for header check?

["mdedetrich (via GitHub)" <gi...@apache.org>]

mdedetrich commented on issue #210:
URL: https://github.com/apache/incubator-pekko/issues/210#issuecomment-1437677505

   So to clarify, I am not talking about re-implementing sbt-header. Rather the proposed sbt plugin that I speak of would just be an auto plugin that extends sbt-header with the logic in `CopyrightHeader`, so you can think of it more as just abstracting away our current header checking into a library rather than re-implementing sbt-header.
   
   > it seems to update some project scala files but not all. Not really sure why it seems to update some but certainly seeing many that don't get updated. In the end, we can hand modify some files if it is easier.
   
   This is due to what I mentioned, sbt plugins/settings generally only apply to the parent project, not itself. It might be hard to conceptualize, but basically any plugins in `project` only apply to the root source, so if you want a sbt plugin to apply to the sources of an sbt project then you need to add the plugin to `project/project/plugins.sbt` (and you can do this endlessly but in our case we only need to do it once).
   
   Even aside of this limitation, there is merit at last at some point in having this as an sbt plugin because just like the other sbt plugins we created, this is going to be common logic that will have to apply to every single Pekko project.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org