You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/06/10 15:57:48 UTC

[GitHub] [arrow] lidavidm commented on a change in pull request #10482: ARROW-12597: [C++] Enable per-row-group parallelism in async Parquet reader

lidavidm commented on a change in pull request #10482:
URL: https://github.com/apache/arrow/pull/10482#discussion_r649318943



##########
File path: cpp/src/parquet/arrow/reader.cc
##########
@@ -1134,6 +1138,42 @@ Status FileReaderImpl::DecodeRowGroups(const std::vector<int>& row_groups,
   return (*out)->Validate();
 }
 
+Future<std::shared_ptr<Table>> FileReaderImpl::DecodeRowGroups(

Review comment:
       It would be a little awkward since the async one holds a shared_ptr to self and the sync one has no need to, and given the class is often used as a unique_ptr, we also can't add enable_shared_from_this. Hmm, but we could probably do some branching and combine them into one implementation again (and just have the sync version wait on the future).




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org