You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@falcon.apache.org by Ajay Yadava <aj...@gmail.com> on 2014/12/15 15:46:45 UTC

Review Request 29050: Add path matching ability to the radix tree

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29050/
-----------------------------------------------------------

Review request for Falcon and Srikanth Sundarrajan.


Bugs: FALCON-823
    https://issues.apache.org/jira/browse/FALCON-823


Repository: falcon-git


Description
-------

We need two types of iterations on the Radix Tree. One to find the normal string match with the key and another one to do a regex iteration so that we can give feed's instance path and match with feed's template. This patch adds support for latter.


Diffs
-----

  common/src/main/java/org/apache/falcon/entity/common/FeedDataPath.java 39e636b 
  common/src/main/java/org/apache/falcon/entity/store/FeedPathStore.java 97d21c1 
  common/src/main/java/org/apache/falcon/util/FalconRadixUtils.java PRE-CREATION 
  common/src/main/java/org/apache/falcon/util/RadixNode.java 564df8e 
  common/src/main/java/org/apache/falcon/util/RadixTree.java 6dbe160 
  common/src/test/java/org/apache/falcon/entity/FeedDataPathTest.java PRE-CREATION 
  common/src/test/java/org/apache/falcon/entity/FeedHelperTest.java f6994fc 
  common/src/test/java/org/apache/falcon/util/RadixNodeTest.java 4f63806 
  common/src/test/java/org/apache/falcon/util/RadixTreeTest.java 28589ed 

Diff: https://reviews.apache.org/r/29050/diff/


Testing
-------

UT have been augmented for the new feature.


Thanks,

Ajay Yadava


Re: Review Request 29050: Add path matching ability to the radix tree

Posted by Srikanth Sundarrajan <sr...@hotmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29050/#review66130
-----------------------------------------------------------

Ship it!


Ship It!

- Srikanth Sundarrajan


On Dec. 26, 2014, 1:39 a.m., Ajay Yadava wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29050/
> -----------------------------------------------------------
> 
> (Updated Dec. 26, 2014, 1:39 a.m.)
> 
> 
> Review request for Falcon and Srikanth Sundarrajan.
> 
> 
> Bugs: FALCON-823
>     https://issues.apache.org/jira/browse/FALCON-823
> 
> 
> Repository: falcon-git
> 
> 
> Description
> -------
> 
> We need two types of iterations on the Radix Tree. One to find the normal string match with the key and another one to do a regex iteration so that we can give feed's instance path and match with feed's template. This patch adds support for latter.
> 
> 
> Diffs
> -----
> 
>   common/src/main/java/org/apache/falcon/entity/common/FeedDataPath.java 39e636b 
>   common/src/main/java/org/apache/falcon/entity/store/FeedPathStore.java 97d21c1 
>   common/src/main/java/org/apache/falcon/util/FalconRadixUtils.java PRE-CREATION 
>   common/src/main/java/org/apache/falcon/util/RadixNode.java 564df8e 
>   common/src/main/java/org/apache/falcon/util/RadixTree.java 6dbe160 
>   common/src/test/java/org/apache/falcon/entity/FeedDataPathTest.java PRE-CREATION 
>   common/src/test/java/org/apache/falcon/util/RadixNodeTest.java 4f63806 
>   common/src/test/java/org/apache/falcon/util/RadixTreeTest.java 28589ed 
> 
> Diff: https://reviews.apache.org/r/29050/diff/
> 
> 
> Testing
> -------
> 
> UT have been augmented for the new feature.
> 
> 
> Thanks,
> 
> Ajay Yadava
> 
>


Re: Review Request 29050: Add path matching ability to the radix tree

Posted by Srikanth Sundarrajan <sr...@hotmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29050/#review66120
-----------------------------------------------------------



common/src/test/java/org/apache/falcon/util/RadixTreeTest.java
<https://reviews.apache.org/r/29050/#comment109477>

    Since find() is annotated as @Nullable, IDE warns that the return value might be null. If findbugs does report them, then these needs to be resolved


- Srikanth Sundarrajan


On Dec. 26, 2014, 1:39 a.m., Ajay Yadava wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29050/
> -----------------------------------------------------------
> 
> (Updated Dec. 26, 2014, 1:39 a.m.)
> 
> 
> Review request for Falcon and Srikanth Sundarrajan.
> 
> 
> Bugs: FALCON-823
>     https://issues.apache.org/jira/browse/FALCON-823
> 
> 
> Repository: falcon-git
> 
> 
> Description
> -------
> 
> We need two types of iterations on the Radix Tree. One to find the normal string match with the key and another one to do a regex iteration so that we can give feed's instance path and match with feed's template. This patch adds support for latter.
> 
> 
> Diffs
> -----
> 
>   common/src/main/java/org/apache/falcon/entity/common/FeedDataPath.java 39e636b 
>   common/src/main/java/org/apache/falcon/entity/store/FeedPathStore.java 97d21c1 
>   common/src/main/java/org/apache/falcon/util/FalconRadixUtils.java PRE-CREATION 
>   common/src/main/java/org/apache/falcon/util/RadixNode.java 564df8e 
>   common/src/main/java/org/apache/falcon/util/RadixTree.java 6dbe160 
>   common/src/test/java/org/apache/falcon/entity/FeedDataPathTest.java PRE-CREATION 
>   common/src/test/java/org/apache/falcon/util/RadixNodeTest.java 4f63806 
>   common/src/test/java/org/apache/falcon/util/RadixTreeTest.java 28589ed 
> 
> Diff: https://reviews.apache.org/r/29050/diff/
> 
> 
> Testing
> -------
> 
> UT have been augmented for the new feature.
> 
> 
> Thanks,
> 
> Ajay Yadava
> 
>


Re: Review Request 29050: Add path matching ability to the radix tree

Posted by Ajay Yadava <aj...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29050/
-----------------------------------------------------------

(Updated Dec. 26, 2014, 1:39 a.m.)


Review request for Falcon and Srikanth Sundarrajan.


Changes
-------

Implemented code review comments.


Bugs: FALCON-823
    https://issues.apache.org/jira/browse/FALCON-823


Repository: falcon-git


Description
-------

We need two types of iterations on the Radix Tree. One to find the normal string match with the key and another one to do a regex iteration so that we can give feed's instance path and match with feed's template. This patch adds support for latter.


Diffs (updated)
-----

  common/src/main/java/org/apache/falcon/entity/common/FeedDataPath.java 39e636b 
  common/src/main/java/org/apache/falcon/entity/store/FeedPathStore.java 97d21c1 
  common/src/main/java/org/apache/falcon/util/FalconRadixUtils.java PRE-CREATION 
  common/src/main/java/org/apache/falcon/util/RadixNode.java 564df8e 
  common/src/main/java/org/apache/falcon/util/RadixTree.java 6dbe160 
  common/src/test/java/org/apache/falcon/entity/FeedDataPathTest.java PRE-CREATION 
  common/src/test/java/org/apache/falcon/util/RadixNodeTest.java 4f63806 
  common/src/test/java/org/apache/falcon/util/RadixTreeTest.java 28589ed 

Diff: https://reviews.apache.org/r/29050/diff/


Testing
-------

UT have been augmented for the new feature.


Thanks,

Ajay Yadava